Skip to content

Comments

Raw Therapee label#1380

Merged
acodega merged 3 commits intoInstallomator:mainfrom
Theile:RawTherapee-label
Jan 16, 2025
Merged

Raw Therapee label#1380
acodega merged 3 commits intoInstallomator:mainfrom
Theile:RawTherapee-label

Conversation

@Theile
Copy link
Collaborator

@Theile Theile commented Dec 19, 2023

An Open Source RAW Converter

@Theile Theile added the application adds or improves an application label label Dec 19, 2023
@Theile Theile added this to the v10.6 milestone Dec 19, 2023
@BigMacAdmin BigMacAdmin self-assigned this Mar 12, 2024
@BigMacAdmin
Copy link
Collaborator

BigMacAdmin commented Mar 12, 2024

I am having issues with this label. It looks like the .zip contains a folder which then contains a .dmg.

Installomator is attempting to mount: /Users/bigmacadmin/Documents/GitHub/installomator/build/RawTherapee_macOS_13.3_Universal_5.10.dmg

however, the full path is actually: /Users/bigmacadmin/Documents/GitHub/installomator/build/RawTherapee_macOS_13.3_Universal_5.10_folder/RawTherapee_macOS_13.3_Universal_5.10.dmg

Is it possible to get Installomator to find this dmg by adjusting the label? Or would we require an improvement to how Installomator locates the DMG path?

./utils/test-pr.sh 1380 rawtherapee
From https://github.com/Installomator/Installomator
 * branch            refs/pull/1380/head -> FETCH_HEAD
Already up to date.
2024-03-11 23:10:32 : REQ   : rawtherapee : ################## Start Installomator v. 10.6beta, date 2024-03-11
2024-03-11 23:10:32 : INFO  : rawtherapee : ################## Version: 10.6beta
2024-03-11 23:10:32 : INFO  : rawtherapee : ################## Date: 2024-03-11
2024-03-11 23:10:32 : INFO  : rawtherapee : ################## rawtherapee
2024-03-11 23:10:32 : DEBUG : rawtherapee : DEBUG mode 1 enabled.
2024-03-11 23:10:33 : DEBUG : rawtherapee : name=RawTherapee
2024-03-11 23:10:33 : DEBUG : rawtherapee : appName=
2024-03-11 23:10:33 : DEBUG : rawtherapee : type=appInDmgInZip
2024-03-11 23:10:33 : DEBUG : rawtherapee : archiveName=
2024-03-11 23:10:33 : DEBUG : rawtherapee : downloadURL=https://rawtherapee.com/shared/builds/mac/RawTherapee_macOS_13.3_Universal_5.10.zip
2024-03-11 23:10:33 : DEBUG : rawtherapee : curlOptions=
2024-03-11 23:10:33 : DEBUG : rawtherapee : appNewVersion=5.10
2024-03-11 23:10:33 : DEBUG : rawtherapee : appCustomVersion function: Not defined
2024-03-11 23:10:33 : DEBUG : rawtherapee : versionKey=CFBundleShortVersionString
2024-03-11 23:10:33 : DEBUG : rawtherapee : packageID=
2024-03-11 23:10:33 : DEBUG : rawtherapee : pkgName=
2024-03-11 23:10:33 : DEBUG : rawtherapee : choiceChangesXML=
2024-03-11 23:10:33 : DEBUG : rawtherapee : expectedTeamID=5SJ86G6Q2R
2024-03-11 23:10:33 : DEBUG : rawtherapee : blockingProcesses=
2024-03-11 23:10:33 : DEBUG : rawtherapee : installerTool=
2024-03-11 23:10:33 : DEBUG : rawtherapee : CLIInstaller=
2024-03-11 23:10:33 : DEBUG : rawtherapee : CLIArguments=
2024-03-11 23:10:33 : DEBUG : rawtherapee : updateTool=
2024-03-11 23:10:33 : DEBUG : rawtherapee : updateToolArguments=
2024-03-11 23:10:33 : DEBUG : rawtherapee : updateToolRunAsCurrentUser=
2024-03-11 23:10:33 : INFO  : rawtherapee : BLOCKING_PROCESS_ACTION=tell_user
2024-03-11 23:10:33 : INFO  : rawtherapee : NOTIFY=success
2024-03-11 23:10:33 : INFO  : rawtherapee : LOGGING=DEBUG
2024-03-11 23:10:33 : INFO  : rawtherapee : LOGO=/System/Applications/App Store.app/Contents/Resources/AppIcon.icns
2024-03-11 23:10:33 : INFO  : rawtherapee : Label type: appInDmgInZip
2024-03-11 23:10:33 : INFO  : rawtherapee : archiveName: RawTherapee.zip
2024-03-11 23:10:33 : INFO  : rawtherapee : no blocking processes defined, using RawTherapee as default
2024-03-11 23:10:33 : DEBUG : rawtherapee : Changing directory to /Users/bigmacadmin/Documents/GitHub/installomator/build
2024-03-11 23:10:33 : INFO  : rawtherapee : name: RawTherapee, appName: RawTherapee.app
2024-03-11 23:10:33.308 mdfind[8200:5446723] [UserQueryParser] Loading keywords and predicates for locale "en_US"
2024-03-11 23:10:33.308 mdfind[8200:5446723] [UserQueryParser] Loading keywords and predicates for locale "en"
2024-03-11 23:10:33.373 mdfind[8200:5446723] Couldn't determine the mapping between prefab keywords and predicates.
2024-03-11 23:10:33 : WARN  : rawtherapee : No previous app found
2024-03-11 23:10:33 : WARN  : rawtherapee : could not find RawTherapee.app
2024-03-11 23:10:33 : INFO  : rawtherapee : appversion: 
2024-03-11 23:10:33 : INFO  : rawtherapee : Latest version of RawTherapee is 5.10
2024-03-11 23:10:33 : REQ   : rawtherapee : Downloading https://rawtherapee.com/shared/builds/mac/RawTherapee_macOS_13.3_Universal_5.10.zip to RawTherapee.zip
2024-03-11 23:10:33 : DEBUG : rawtherapee : No Dialog connection, just download
2024-03-11 23:10:48 : DEBUG : rawtherapee : File list: -rw-r--r--  1 bigmacadmin  staff   141M Mar 11 23:10 RawTherapee.zip
2024-03-11 23:10:48 : DEBUG : rawtherapee : File type: RawTherapee.zip: Zip archive data, at least v1.0 to extract, compression method=store
2024-03-11 23:10:48 : DEBUG : rawtherapee : curl output was:
*   Trying 37.9.175.165:443...
* Connected to rawtherapee.com (37.9.175.165) port 443
* ALPN: curl offers h2,http/1.1
* (304) (OUT), TLS handshake, Client hello (1):
} [320 bytes data]
*  CAfile: /etc/ssl/cert.pem
*  CApath: none
* (304) (IN), TLS handshake, Server hello (2):
{ [122 bytes data]
* (304) (IN), TLS handshake, Unknown (8):
{ [19 bytes data]
* (304) (IN), TLS handshake, Certificate (11):
{ [4250 bytes data]
* (304) (IN), TLS handshake, CERT verify (15):
{ [520 bytes data]
* (304) (IN), TLS handshake, Finished (20):
{ [36 bytes data]
* (304) (OUT), TLS handshake, Finished (20):
} [36 bytes data]
* SSL connection using TLSv1.3 / AEAD-CHACHA20-POLY1305-SHA256
* ALPN: server accepted h2
* Server certificate:
*  subject: CN=rawtherapee.com
*  start date: Feb 24 11:42:15 2024 GMT
*  expire date: May 24 11:42:14 2024 GMT
*  subjectAltName: host "rawtherapee.com" matched cert's "rawtherapee.com"
*  issuer: C=US; O=Let's Encrypt; CN=R3
*  SSL certificate verify ok.
* using HTTP/2
* [HTTP/2] [1] OPENED stream for https://rawtherapee.com/shared/builds/mac/RawTherapee_macOS_13.3_Universal_5.10.zip
* [HTTP/2] [1] [:method: GET]
* [HTTP/2] [1] [:scheme: https]
* [HTTP/2] [1] [:authority: rawtherapee.com]
* [HTTP/2] [1] [:path: /shared/builds/mac/RawTherapee_macOS_13.3_Universal_5.10.zip]
* [HTTP/2] [1] [user-agent: curl/8.4.0]
* [HTTP/2] [1] [accept: */*]
> GET /shared/builds/mac/RawTherapee_macOS_13.3_Universal_5.10.zip HTTP/2
> Host: rawtherapee.com
> User-Agent: curl/8.4.0
> Accept: */*
> 
< HTTP/2 200 
< server: openresty
< date: Tue, 12 Mar 2024 06:10:33 GMT
< content-type: application/zip
< content-length: 147545603
< last-modified: Sat, 17 Feb 2024 04:58:14 GMT
< etag: "8cb5e03-6118cb53ee9e5"
< accept-ranges: bytes
< 
{ [3946 bytes data]
* Connection #0 to host rawtherapee.com left intact

2024-03-11 23:10:48 : DEBUG : rawtherapee : DEBUG mode 1, not checking for blocking processes
2024-03-11 23:10:48 : REQ   : rawtherapee : Installing RawTherapee
2024-03-11 23:10:48 : INFO  : rawtherapee : Unzipping RawTherapee.zip
2024-03-11 23:10:48 : INFO  : rawtherapee : found dmg: /Users/bigmacadmin/Documents/GitHub/installomator/build/RawTherapee_macOS_13.3_Universal_5.10.dmg
2024-03-11 23:10:48 : INFO  : rawtherapee : Mounting /Users/bigmacadmin/Documents/GitHub/installomator/build/RawTherapee_macOS_13.3_Universal_5.10.dmg
hdiutil: attach failed - No such file or directory
2024-03-11 23:10:48 : DEBUG : rawtherapee : DEBUG mode 1, not reopening anything
2024-03-11 23:10:48 : ERROR : rawtherapee : ERROR: Error mounting /Users/bigmacadmin/Documents/GitHub/installomator/build/RawTherapee_macOS_13.3_Universal_5.10.dmg error:
Log

2024-03-11 23:10:49 : REQ   : rawtherapee : ################## End Installomator, exit code 3 

something went wrong, stopping here

@Theile
Copy link
Collaborator Author

Theile commented May 23, 2024

It cannot mount the DMG, as it has a long license to read. Not really sure how to fix this.

@Theile Theile removed this from the v10.6 milestone May 23, 2024
@Theile Theile added bug Something isn't working and removed waiting for response labels May 23, 2024
@acodega
Copy link
Collaborator

acodega commented Sep 2, 2024 •
edited
Loading

@Theile We pipe yes to the mount command that should account for accepting license/TOS.

Installomator/fragments/functions.sh

Line 597 in 1e7e830

mountDMG() {
Should this label be closed out or can it be updated?

@acodega
Update rawtherapee.sh
c6d0b39 
Removed comment lines from label
@acodega acodega removed bug Something isn't working waiting for response labels Jan 16, 2025
@acodega acodega added this to the v10.7 milestone Jan 16, 2025
@acodega acodega merged commit 9487216 into Installomator:main Jan 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scriptingosx scriptingosx Awaiting requested review from scriptingosx

Assignees

@BigMacAdmin BigMacAdmin

Labels

application adds or improves an application label

Projects

None yet

Milestone

v10.7

Development

Successfully merging this pull request may close these issues.

3 participants

@Theile @BigMacAdmin @acodega