Skip to content

Comments

ZuluJDK DownloadURL Fixes#1374

Closed
drtaru wants to merge 1 commit intoInstallomator:mainfrom
drtaru:fixZuluJDK
Closed

ZuluJDK DownloadURL Fixes#1374
drtaru wants to merge 1 commit intoInstallomator:mainfrom
drtaru:fixZuluJDK

Conversation

@drtaru
Copy link
Contributor

@drtaru drtaru commented Dec 14, 2023

ZuluJDK DMG Downloads were failing.
Fixed DownloadURL logic for all versions to create the correct functional URL.

@kryptonit1
Copy link
Contributor

kryptonit1 commented Jan 22, 2024

The zulujdk8 label does not work on Intel devices. The download variable returns a very old version of Zulu OpenJDK 8 (zulu8.9.0.4-ca-jdk8.0.60-macosx_x64.dmg).

Changing the downloadURL variable to this fixes the problem:
downloadURL=https://cdn.azul.com/zulu/bin/$(curl -fs "https://cdn.azul.com/zulu/bin/" | grep -Eio '">zulu8.*ca-jdk8.*x64.dmg(.*)' | cut -c3- | sed 's/<\/a><\/td>//' | sed -E 's/([0-9.]*)M//' | awk '{print $2 $1}' | sort -V | tail -1)

@BigMacAdmin
Copy link
Collaborator

@drtaru can you please address or respond to @kryptonit1 's comment for zulujdk8 ?

@BigMacAdmin BigMacAdmin added application adds or improves an application label waiting for response labels Mar 12, 2024
@BigMacAdmin BigMacAdmin self-assigned this Mar 12, 2024
@drtaru
Copy link
Contributor Author

drtaru commented Mar 12, 2024

More work needs to be done on this apparently. I don't have any bandwidth to work on or push a fix at the moment.

@BigMacAdmin
Copy link
Collaborator

Closing due to open issues with no interest to fix

kryptonit1 added a commit to kryptonit1/Installomator that referenced this pull request Mar 27, 2024
Fixes the downloadURL variable for the zulujdk8 label which was not fully addressed by the original author in Installomator#1374.
@kryptonit1 kryptonit1 mentioned this pull request Mar 27, 2024
@drtaru drtaru deleted the fixZuluJDK branch December 10, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants