FIXED: OBS file name format changed #1335#1344
Merged
BigMacAdmin merged 1 commit intoInstallomator:mainfrom Mar 29, 2024
Merged
FIXED: OBS file name format changed #1335#1344BigMacAdmin merged 1 commit intoInstallomator:mainfrom
BigMacAdmin merged 1 commit intoInstallomator:mainfrom
Conversation
Updated the OBS label to use the sparkle feed, it seems more robust than the github approach. 2023-11-22 17:35:33 : REQ : obs : ################## Start Installomator v. 10.6beta, date 2023-11-22 2023-11-22 17:35:33 : INFO : obs : ################## Version: 10.6beta 2023-11-22 17:35:33 : INFO : obs : ################## Date: 2023-11-22 2023-11-22 17:35:33 : INFO : obs : ################## obs 2023-11-22 17:35:33 : DEBUG : obs : DEBUG mode 1 enabled. 2023-11-22 17:35:35 : DEBUG : obs : name=OBS 2023-11-22 17:35:35 : DEBUG : obs : appName= 2023-11-22 17:35:35 : DEBUG : obs : type=dmg 2023-11-22 17:35:35 : DEBUG : obs : archiveName=obs-studio-30.0.0-macos-apple.dmg 2023-11-22 17:35:35 : DEBUG : obs : downloadURL=https://cdn-fastly.obsproject.com/downloads/obs-studio-30.0.0-macos-apple.dmg 2023-11-22 17:35:35 : DEBUG : obs : curlOptions= 2023-11-22 17:35:35 : DEBUG : obs : appNewVersion=30.0.0 2023-11-22 17:35:35 : DEBUG : obs : appCustomVersion function: Not defined 2023-11-22 17:35:35 : DEBUG : obs : versionKey=CFBundleShortVersionString 2023-11-22 17:35:35 : DEBUG : obs : packageID= 2023-11-22 17:35:35 : DEBUG : obs : pkgName= 2023-11-22 17:35:35 : DEBUG : obs : choiceChangesXML= 2023-11-22 17:35:35 : DEBUG : obs : expectedTeamID=2MMRE5MTB8 2023-11-22 17:35:35 : DEBUG : obs : blockingProcesses=OBS Studio 2023-11-22 17:35:35 : DEBUG : obs : installerTool= 2023-11-22 17:35:35 : DEBUG : obs : CLIInstaller= 2023-11-22 17:35:35 : DEBUG : obs : CLIArguments= 2023-11-22 17:35:35 : DEBUG : obs : updateTool= 2023-11-22 17:35:35 : DEBUG : obs : updateToolArguments= 2023-11-22 17:35:35 : DEBUG : obs : updateToolRunAsCurrentUser= 2023-11-22 17:35:35 : INFO : obs : BLOCKING_PROCESS_ACTION=tell_user 2023-11-22 17:35:35 : INFO : obs : NOTIFY=success 2023-11-22 17:35:35 : INFO : obs : LOGGING=DEBUG 2023-11-22 17:35:35 : INFO : obs : LOGO=/System/Applications/App Store.app/Contents/Resources/AppIcon.icns 2023-11-22 17:35:35 : INFO : obs : Label type: dmg 2023-11-22 17:35:35 : INFO : obs : archiveName: obs-studio-30.0.0-macos-apple.dmg 2023-11-22 17:35:35 : DEBUG : obs : Changing directory to /Users/someuser/Documents/GitHub/Installomator/build 2023-11-22 17:35:35 : INFO : obs : App(s) found: /Applications/OBS.app 2023-11-22 17:35:35 : INFO : obs : found app at /Applications/OBS.app, version 29.1.3, on versionKey CFBundleShortVersionString 2023-11-22 17:35:35 : INFO : obs : appversion: 29.1.3 2023-11-22 17:35:35 : INFO : obs : Latest version of OBS is 30.0.0 2023-11-22 17:35:35 : INFO : obs : obs-studio-30.0.0-macos-apple.dmg exists and DEBUG mode 1 enabled, skipping download 2023-11-22 17:35:35 : DEBUG : obs : DEBUG mode 1, not checking for blocking processes 2023-11-22 17:35:35 : REQ : obs : Installing OBS 2023-11-22 17:35:35 : INFO : obs : Mounting /Users/someuser/Documents/GitHub/Installomator/build/obs-studio-30.0.0-macos-apple.dmg 2023-11-22 17:35:36 : DEBUG : obs : Debugging enabled, dmgmount output was: expected CRC32 $F2112CCD /dev/disk5 GUID_partition_scheme /dev/disk5s1 Apple_HFS /Volumes/OBS Studio 30.0.0 (Apple) 2023-11-22 17:35:36 : INFO : obs : Mounted: /Volumes/OBS Studio 30.0.0 (Apple) 2023-11-22 17:35:36 : INFO : obs : Verifying: /Volumes/OBS Studio 30.0.0 (Apple)/OBS.app 2023-11-22 17:35:36 : DEBUG : obs : App size: 391M /Volumes/OBS Studio 30.0.0 (Apple)/OBS.app 2023-11-22 17:35:40 : DEBUG : obs : Debugging enabled, App Verification output was: /Volumes/OBS Studio 30.0.0 (Apple)/OBS.app: accepted source=Notarized Developer ID origin=Developer ID Application: Wizards of OBS LLC (2MMRE5MTB8) 2023-11-22 17:35:40 : INFO : obs : Team ID matching: 2MMRE5MTB8 (expected: 2MMRE5MTB8 ) 2023-11-22 17:35:40 : INFO : obs : Downloaded version of OBS is 30.0.0 on versionKey CFBundleShortVersionString (replacing version 29.1.3). 2023-11-22 17:35:40 : INFO : obs : App has LSMinimumSystemVersion: 11.0 2023-11-22 17:35:40 : DEBUG : obs : DEBUG mode 1 enabled, skipping remove, copy and chown steps 2023-11-22 17:35:40 : INFO : obs : Finishing... 2023-11-22 17:35:43 : INFO : obs : App(s) found: /Applications/OBS.app 2023-11-22 17:35:44 : INFO : obs : found app at /Applications/OBS.app, version 29.1.3, on versionKey CFBundleShortVersionString 2023-11-22 17:35:44 : REQ : obs : Installed OBS, version 30.0.0 2023-11-22 17:35:44 : INFO : obs : notifying 2023-11-22 17:35:44 : DEBUG : obs : Unmounting /Volumes/OBS Studio 30.0.0 (Apple) 2023-11-22 17:35:44 : DEBUG : obs : Debugging enabled, Unmounting output was: "disk5" ejected. 2023-11-22 17:35:44 : DEBUG : obs : DEBUG mode 1, not reopening anything 2023-11-22 17:35:44 : REQ : obs : All done! 2023-11-22 17:35:44 : REQ : obs : ################## End Installomator, exit code 0
07-C9
approved these changes
Jan 5, 2024
Contributor
There was a problem hiding this comment.
Can confirm this fixed the issues I was having with the previous version of the label:
2024-01-04 18:28:34 : INFO : obs : App(s) found: /Applications/OBS.app
2024-01-04 18:28:34 : INFO : obs : found app at /Applications/OBS.app, version 27.1.3, on versionKey CFBundleShortVersionString
2024-01-04 18:28:34 : INFO : obs : appversion: 27.1.3
2024-01-04 18:28:34 : INFO : obs : Label is not of type “updateronly”, and it’s set to use force to install or ignoring app store apps, so not using updateTool.
2024-01-04 18:28:34 : INFO : obs : Latest version of OBS is 30.0.2
2024-01-04 18:28:34 : REQ : obs : Downloading https://github.com/ to obs-studio-[0-9.]*-macos-x86_64.dmg
2024-01-04 18:28:34 : REQ : obs : no more blocking processes, continue with update
2024-01-04 18:28:34 : REQ : obs : Installing OBS
2024-01-04 18:28:34 : INFO : obs : Mounting /var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/T/tmp.2i1M72n8/obs-studio-[0-9.]*-macos-x86_64.dmg
hdiutil: attach failed - image not recognized
2024-01-04 18:28:34 : INFO : obs : Installomator did not close any apps, so no need to reopen any apps.
2024-01-04 18:28:34 : ERROR : obs : ERROR: Error mounting /var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/T/tmp.2i1M72n8/obs-studio-[0-9.]*-macos-x86_64.dmg error:
Log
2024-01-04 18:28:34 : REQ : obs : ################## End Installomator, exit code 3
Error running script: return code was 3.
and after testing your change:
2024-01-04 18:46:17 : INFO : obs : App(s) found: /Applications/OBS.app
2024-01-04 18:46:17 : INFO : obs : found app at /Applications/OBS.app, version 27.1.3, on versionKey CFBundleShortVersionString
2024-01-04 18:46:17 : INFO : obs : appversion: 27.1.3
2024-01-04 18:46:17 : INFO : obs : Label is not of type “updateronly”, and it’s set to use force to install or ignoring app store apps, so not using updateTool.
2024-01-04 18:46:17 : INFO : obs : Latest version of OBS is 30.0.2
2024-01-04 18:46:17 : REQ : obs : Downloading https://cdn-fastly.obsproject.com/downloads/obs-studio-30.0.2-macos-intel.dmg to obs-studio-30.0.2-macos-intel.dmg
2024-01-04 18:46:33 : REQ : obs : no more blocking processes, continue with update
2024-01-04 18:46:34 : REQ : obs : Installing OBS
2024-01-04 18:46:34 : INFO : obs : Mounting /var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/T/tmp.Rc2RijNV/obs-studio-30.0.2-macos-intel.dmg
2024-01-04 18:46:36 : INFO : obs : Mounted: /Volumes/OBS Studio 30.0.2 (Intel)
2024-01-04 18:46:36 : INFO : obs : Verifying: /Volumes/OBS Studio 30.0.2 (Intel)/OBS.app
2024-01-04 18:46:48 : INFO : obs : Team ID matching: 2MMRE5MTB8 (expected: 2MMRE5MTB8 )
2024-01-04 18:46:48 : INFO : obs : Downloaded version of OBS is 30.0.2 on versionKey CFBundleShortVersionString (replacing version 27.1.3).
2024-01-04 18:46:48 : INFO : obs : App has LSMinimumSystemVersion: 11.0
2024-01-04 18:46:48 : WARN : obs : Removing existing /Applications/OBS.app
2024-01-04 18:46:49 : INFO : obs : Copy /Volumes/OBS Studio 30.0.2 (Intel)/OBS.app to /Applications
2024-01-04 18:46:57 : WARN : obs : Changing owner to Administrator
2024-01-04 18:46:58 : INFO : obs : Finishing...
2024-01-04 18:47:01 : INFO : obs : App(s) found: /Applications/OBS.app
2024-01-04 18:47:02 : INFO : obs : found app at /Applications/OBS.app, version 30.0.2, on versionKey CFBundleShortVersionString
2024-01-04 18:47:02 : REQ : obs : Installed OBS, version 30.0.2
2024-01-04 18:47:13 : INFO : obs : Installomator did not close any apps, so no need to reopen any apps.
2024-01-04 18:47:13 : REQ : obs : All done!
2024-01-04 18:47:13 : REQ : obs : ################## End Installomator, exit code 0
Success!
Collaborator
|
Trying to get through the backlog here, sorry for the delay. Is there a good reason to move to parsing the Sparkle Feed rather than using Github Releases? Does the Github lag behind compared to updates posted to the Sparkle Feed? |
BigMacAdmin
added
application
Closed
Contributor
Author
|
@BigMacAdmin Sorry for the late response. I was off sick all last week. I am having trouble remembering the exact reason now, but I think it was because I found that due to the GitHub project having multiple versions and platforms on their release page. And I believe that the Sparkle approach was more consistent and efficient than than the GitHub approach, at least for OBS, that is. |
|
I tested this updated version and it seems to work to pull the new version of OBS from the Github page. obs) |
Contributor
|
@greatkemo's fix that was working beautifully, started error'ing out for me. The appNewVersion isn't returning anything for me either. I don't recall which of these was which, sorry. Download URL on that one wasn't working correctly for me. Other one: Download URL appears to have 404'd. Those were both on the same machine, just trying to get OBS updated. I tried my hand at it and came up with this: Not able to run it on any computers that have an outdated version of OBS, but as a fresh install it works on my machine: |
Contributor
Author
|
@itsbradwhite The 404 you were getting was due to issues with their site on the day or some network issue. After testing the label again, it is working as expected. From your output, it seems that appNewVersion is being scraped from the sparkle feed and applied; you can verify that from this line: To test, I ran the checkLabels script. Then I ran the assemble script just to be sure: |
Collaborator
|
Thank you! |
Collaborator
|
I merged this, and then got word from @robjschroeder that the label wasn't working. It looks like OBS missed posting a version on their sparkle feed that was available on github, leading this label using a version that was 2 weeks behind. OBS then released a new version yesterday on both Sparkle and Github. To me, this is a good reason to go back to using Github rather than the Sparkle feed, but I would appreciate anyone weighing in with more info. See PR #1581 |
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the OBS label to use the sparkle feed, it seems more robust than the github approach.
2023-11-22 17:35:33 : REQ : obs : ################## Start Installomator v. 10.6beta, date 2023-11-22
2023-11-22 17:35:33 : INFO : obs : ################## Version: 10.6beta
2023-11-22 17:35:33 : INFO : obs : ################## Date: 2023-11-22
2023-11-22 17:35:33 : INFO : obs : ################## obs
2023-11-22 17:35:33 : DEBUG : obs : DEBUG mode 1 enabled.
2023-11-22 17:35:35 : DEBUG : obs : name=OBS
2023-11-22 17:35:35 : DEBUG : obs : appName=
2023-11-22 17:35:35 : DEBUG : obs : type=dmg
2023-11-22 17:35:35 : DEBUG : obs : archiveName=obs-studio-30.0.0-macos-apple.dmg
2023-11-22 17:35:35 : DEBUG : obs : downloadURL=https://cdn-fastly.obsproject.com/downloads/obs-studio-30.0.0-macos-apple.dmg
2023-11-22 17:35:35 : DEBUG : obs : curlOptions=
2023-11-22 17:35:35 : DEBUG : obs : appNewVersion=30.0.0
2023-11-22 17:35:35 : DEBUG : obs : appCustomVersion function: Not defined
2023-11-22 17:35:35 : DEBUG : obs : versionKey=CFBundleShortVersionString
2023-11-22 17:35:35 : DEBUG : obs : packageID=
2023-11-22 17:35:35 : DEBUG : obs : pkgName=
2023-11-22 17:35:35 : DEBUG : obs : choiceChangesXML=
2023-11-22 17:35:35 : DEBUG : obs : expectedTeamID=2MMRE5MTB8
2023-11-22 17:35:35 : DEBUG : obs : blockingProcesses=OBS Studio
2023-11-22 17:35:35 : DEBUG : obs : installerTool=
2023-11-22 17:35:35 : DEBUG : obs : CLIInstaller=
2023-11-22 17:35:35 : DEBUG : obs : CLIArguments=
2023-11-22 17:35:35 : DEBUG : obs : updateTool=
2023-11-22 17:35:35 : DEBUG : obs : updateToolArguments=
2023-11-22 17:35:35 : DEBUG : obs : updateToolRunAsCurrentUser=
2023-11-22 17:35:35 : INFO : obs : BLOCKING_PROCESS_ACTION=tell_user
2023-11-22 17:35:35 : INFO : obs : NOTIFY=success
2023-11-22 17:35:35 : INFO : obs : LOGGING=DEBUG
2023-11-22 17:35:35 : INFO : obs : LOGO=/System/Applications/App Store.app/Contents/Resources/AppIcon.icns
2023-11-22 17:35:35 : INFO : obs : Label type: dmg
2023-11-22 17:35:35 : INFO : obs : archiveName: obs-studio-30.0.0-macos-apple.dmg
2023-11-22 17:35:35 : DEBUG : obs : Changing directory to /Users/someuser/Documents/GitHub/Installomator/build
2023-11-22 17:35:35 : INFO : obs : App(s) found: /Applications/OBS.app
2023-11-22 17:35:35 : INFO : obs : found app at /Applications/OBS.app, version 29.1.3, on versionKey CFBundleShortVersionString
2023-11-22 17:35:35 : INFO : obs : appversion: 29.1.3
2023-11-22 17:35:35 : INFO : obs : Latest version of OBS is 30.0.0
2023-11-22 17:35:35 : INFO : obs : obs-studio-30.0.0-macos-apple.dmg exists and DEBUG mode 1 enabled, skipping download
2023-11-22 17:35:35 : DEBUG : obs : DEBUG mode 1, not checking for blocking processes
2023-11-22 17:35:35 : REQ : obs : Installing OBS
2023-11-22 17:35:35 : INFO : obs : Mounting /Users/someuser/Documents/GitHub/Installomator/build/obs-studio-30.0.0-macos-apple.dmg
2023-11-22 17:35:36 : DEBUG : obs : Debugging enabled, dmgmount output was:
expected CRC32 $F2112CCD
/dev/disk5 GUID_partition_scheme
/dev/disk5s1 Apple_HFS /Volumes/OBS Studio 30.0.0 (Apple)
2023-11-22 17:35:36 : INFO : obs : Mounted: /Volumes/OBS Studio 30.0.0 (Apple) 2023-11-22 17:35:36 : INFO : obs : Verifying: /Volumes/OBS Studio 30.0.0 (Apple)/OBS.app
2023-11-22 17:35:36 : DEBUG : obs : App size: 391M /Volumes/OBS Studio 30.0.0 (Apple)/OBS.app
2023-11-22 17:35:40 : DEBUG : obs : Debugging enabled, App Verification output was:
/Volumes/OBS Studio 30.0.0 (Apple)/OBS.app: accepted
source=Notarized Developer ID
origin=Developer ID Application: Wizards of OBS LLC (2MMRE5MTB8)
2023-11-22 17:35:40 : INFO : obs : Team ID matching: 2MMRE5MTB8 (expected: 2MMRE5MTB8 ) 2023-11-22 17:35:40 : INFO : obs : Downloaded version of OBS is 30.0.0 on versionKey CFBundleShortVersionString (replacing version 29.1.3). 2023-11-22 17:35:40 : INFO : obs : App has LSMinimumSystemVersion: 11.0 2023-11-22 17:35:40 : DEBUG : obs : DEBUG mode 1 enabled, skipping remove, copy and chown steps 2023-11-22 17:35:40 : INFO : obs : Finishing...
2023-11-22 17:35:43 : INFO : obs : App(s) found: /Applications/OBS.app 2023-11-22 17:35:44 : INFO : obs : found app at /Applications/OBS.app, version 29.1.3, on versionKey CFBundleShortVersionString
2023-11-22 17:35:44 : REQ : obs : Installed OBS, version 30.0.0
2023-11-22 17:35:44 : INFO : obs : notifying
2023-11-22 17:35:44 : DEBUG : obs : Unmounting /Volumes/OBS Studio 30.0.0 (Apple)
2023-11-22 17:35:44 : DEBUG : obs : Debugging enabled, Unmounting output was:
"disk5" ejected.
2023-11-22 17:35:44 : DEBUG : obs : DEBUG mode 1, not reopening anything
2023-11-22 17:35:44 : REQ : obs : All done!
2023-11-22 17:35:44 : REQ : obs : ################## End Installomator, exit code 0