Skip to content

Comments

Added label orcaslicer#1305

Merged
BigMacAdmin merged 8 commits intoInstallomator:mainfrom
robotprom:Orcaslicer
Mar 20, 2024
Merged

Added label orcaslicer#1305
BigMacAdmin merged 8 commits intoInstallomator:mainfrom
robotprom:Orcaslicer

Conversation

@robotprom
Copy link
Contributor

@robotprom robotprom commented Nov 1, 2023

No description provided.

@Theile
Copy link
Collaborator

Theile commented Mar 5, 2024

Something looks wrong in this. archiveName should be defined before the GitHub function, so my best estimate is that label should be this:

orcaslicer)
    name="OrcaSlicer"
    type="dmg"
    if [[ $(arch) == "arm64" ]]; then
        archiveName="OrcaSlicer_Mac_arm64_*.dmg"
    elif [[ $(arch) == "i386" ]]; then
        archiveName="OrcaSlicer_Mac_x86_64_*.dmg"
    fi
    downloadURL="$(downloadURLFromGit SoftFever OrcaSlicer)"
    appNewVersion="$(versionFromGit SoftFever OrcaSlicer)"
    expectedTeamID="XQK7C38HH5"
    ;;

Can you please check this?

@Theile Theile added the question Further information is requested label Mar 5, 2024
@robotprom
Copy link
Contributor Author

robotprom commented Mar 7, 2024

ok, works for me either way.

@BigMacAdmin
Update orcaslicer.sh
d52b23f 
Implementing Theile's suggested fix. The `archiveName` variable does need to come before the github functions or there can be undesired results.
@BigMacAdmin
Update orcaslicer.sh
88afbbf 
Removing quotes from downloadURL and appNewVersion variables
@BigMacAdmin
Update orcaslicer.sh
df2a283 
Reverting all changes, label is not working in testing
@BigMacAdmin
Update orcaslicer.sh
0e35822 
Test again
@BigMacAdmin
Update orcaslicer.sh
216ec75 
Test3
@BigMacAdmin
Update orcaslicer.sh
80c51ab 
test4
@BigMacAdmin
Update orcaslicer.sh
6eae545 
test5
@BigMacAdmin
Copy link
Collaborator

BigMacAdmin commented Mar 20, 2024

Thank you!

@BigMacAdmin BigMacAdmin added application adds or improves an application label waiting for response and removed question Further information is requested waiting for response labels Mar 20, 2024
@BigMacAdmin BigMacAdmin self-assigned this Mar 20, 2024
@BigMacAdmin BigMacAdmin merged commit 75c7827 into Installomator:main Mar 20, 2024
@scriptingosx scriptingosx added this to the v10.6 milestone Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@BigMacAdmin BigMacAdmin

Labels

application adds or improves an application label

Projects

None yet

Milestone

v10.6

Development

Successfully merging this pull request may close these issues.

4 participants

@robotprom @Theile @BigMacAdmin @scriptingosx