Skip to content

Comments

Update protonvpn.sh#1283

Merged
BigMacAdmin merged 2 commits intoInstallomator:mainfrom
loicyannou:patch-1
Mar 5, 2024
Merged

Update protonvpn.sh#1283
BigMacAdmin merged 2 commits intoInstallomator:mainfrom
loicyannou:patch-1

Conversation

@loicyannou
Copy link
Contributor

@loicyannou
Copy link
Contributor Author

Actually, it seems that the curl does not return the correct dmg version (1.9.6 instead of 3.3.3) and I can't figure out why.
I need some help, please

@scriptingosx scriptingosx added help wanted Extra attention is needed application adds or improves an application label labels Nov 16, 2023
@guy-tallon
Copy link
Contributor

https://protonvpn.com/download/macos-update3.xml seems to hold the version

So curl -s "https://protonvpn.com/download/macos-update3.xml" | grep -o 'https*://[^"]*\.dmg' | head -1 should work

@guy-tallon
Copy link
Contributor

protonvpn)
    name="ProtonVPN"
    type="dmg"
    downloadURL=$(curl -s "https://protonvpn.com/download/macos-update3.xml" | grep -o 'https*://[^"]*\.dmg' | head -1)
    appNewVersion=$(echo $downloadURL | sed -e 's/^.*\/Proton.*_v\([0-9.]*\)\.dmg/\1/g')
    expectedTeamID="J6S6Q257EK"
    ;;

@guy-tallon
Copy link
Contributor

guy-tallon commented Nov 16, 2023

Interestingly it pulls a later version that the website

@jnichols35
Copy link
Contributor

jnichols35 commented Nov 16, 2023

The more I go down this rabbit hole, the more confusing it becomes.
I thought I would check out which version was on winget and it's the same as on their github: 3.2.7

But the download link on their site is for: 2.4.3

Basically I was hoping the ios/mac repo could have been used as a source of truth but its on version 3.1.4.

So really nothing makes sense

@guy-tallon
Copy link
Contributor

guy-tallon commented Nov 17, 2023

Haha, yes it's pretty all over the place for macOS. Odd as the other ones are upto date in GitHub.
I guess they've settled on the rss feed

@guy-tallon
Copy link
Contributor

or maybe this

protonvpn)
    name="ProtonVPN"
    type="dmg"
    downloadURL=$(curl -s "https://protonvpn.com/download/macos-update3.xml" | xmllint --xpath 'string(//enclosure/@url)' -)
    appNewVersion=$(echo $downloadURL | sed -e 's/^.*\/Proton.*_v\([0-9.]*\)\.dmg/\1/g')
    expectedTeamID="J6S6Q257EK"
    ;;

@loicyannou Do you want to make another commit?

@loicyannou
Copy link
Contributor Author

Sorry @guy-tallon, I missed your message
Thanks for your help
I updated the commit with your insights

@guy-tallon
Copy link
Contributor

Great! Thank you for updating it

@BigMacAdmin
Copy link
Collaborator

Thank you!

@BigMacAdmin BigMacAdmin merged commit 35297ab into Installomator:main Mar 5, 2024
@scriptingosx scriptingosx added this to the v10.6 milestone Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

application adds or improves an application label help wanted Extra attention is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants