Skip to content

Comments

Updated Label: GraphPad Prism 9#1141

Merged
scriptingosx merged 1 commit intoInstallomator:mainfrom
kryptonit1:prism9-version-fix
Oct 13, 2023
Merged

Updated Label: GraphPad Prism 9#1141
scriptingosx merged 1 commit intoInstallomator:mainfrom
kryptonit1:prism9-version-fix

Conversation

@kryptonit1
Copy link
Contributor

GraphPad Prism 10 has been released (https://www.graphpad.com/updates/prism-1000-release-notes) and this has caused the current appNewVersion variable for the GraphPad Prism 9 label to show version 10.0.0 as the latest version, which is a new major version. It's unlikely that Prism 9 will receive any more updates so I've changed the appNewVersion label to statically be the last released version of Prism 9 (9.5.1) and also created a PR for a Prism 10 label (#1140).

GraphPad Prism 10 has been released (https://www.graphpad.com/updates/prism-1000-release-notes) and this has caused the current appNewVersion variable for the GraphPad Prism 9 label to show version 10.0.0 as the latest version, which is a new major version. It's unlikely that Prism 9 will receive any more updates so I've changed the appNewVersion label to statically be the last released version of Prism 9 (9.5.1) and also created a PR for a Prism 10 label.
@scriptingosx scriptingosx added the application adds or improves an application label label Aug 22, 2023
@scriptingosx scriptingosx added this to the v10.5 milestone Aug 22, 2023
@scriptingosx
Copy link
Collaborator

I don't like that you are hardcoding the appNewVersion here. Are you absolutely certain this is the ultimate version? If so, why keep the label?

@kryptonit1
Copy link
Contributor Author

When a new major version of Prism has been released no new minor version of the previous major version has been released after that during at least the last couple of years (as far as I'm aware). I don't like hardcoding the version either, but I haven't been able to find a new source where I can pull the latest version of Prism 9 from.

I personally don't mind if the GraphPad Prism 9 label is removed completely, but there could be some use cases where some users has got a perpetual license that's only valid for GraphPad Prism 9 and not 10, where you would like to install the latest version of GraphPad Prism 9. But maybe that's not within the scope of Installomator?

@scriptingosx
Copy link
Collaborator

Thank you!

@scriptingosx scriptingosx merged commit 1cc062d into Installomator:main Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

application adds or improves an application label waiting for response

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants