Skip to content

Comments

label update: googledrive - add AppNewVersion#1070

Merged
scriptingosx merged 2 commits intoInstallomator:mainfrom
duderin0:labelUpdate-googledrive-AddVersioning
Jun 19, 2023
Merged

label update: googledrive - add AppNewVersion#1070
scriptingosx merged 2 commits intoInstallomator:mainfrom
duderin0:labelUpdate-googledrive-AddVersioning

Conversation

@duderin0
Copy link
Contributor

For issue #1062

I'm not sure if we should do this, but this is effective to getting the version added to GoogleDrive. I could not find anything on Google's official sites to reference the full version numbers, but chocolatey.org does.

New Output:

sudo ./assemble.sh googledrive
2023-05-30 12:10:44 : REQ : googledrive : ################## Start Installomator v. 10.4beta, date 2023-05-30
2023-05-30 12:10:44 : INFO : googledrive : ################## Version: 10.4beta
2023-05-30 12:10:44 : INFO : googledrive : ################## Date: 2023-05-30
2023-05-30 12:10:44 : INFO : googledrive : ################## googledrive
2023-05-30 12:10:44 : DEBUG : googledrive : DEBUG mode 1 enabled.
2023-05-30 12:10:45 : DEBUG : googledrive : name=Google Drive File Stream
2023-05-30 12:10:45 : DEBUG : googledrive : appName=Google Drive.app
2023-05-30 12:10:45 : DEBUG : googledrive : type=pkgInDmg
2023-05-30 12:10:45 : DEBUG : googledrive : archiveName=
2023-05-30 12:10:45 : DEBUG : googledrive : downloadURL=https://dl.google.com/drive-file-stream/GoogleDriveFileStream.dmg
2023-05-30 12:10:45 : DEBUG : googledrive : curlOptions=
2023-05-30 12:10:45 : DEBUG : googledrive : appNewVersion=
2023-05-30 12:10:45 : DEBUG : googledrive : 75.0.2.0
2023-05-30 12:10:45 : DEBUG : googledrive : appCustomVersion function: Not defined
2023-05-30 12:10:45 : DEBUG : googledrive : versionKey=CFBundleShortVersionString
2023-05-30 12:10:45 : DEBUG : googledrive : packageID=com.google.drivefs.arm64
2023-05-30 12:10:45 : DEBUG : googledrive : pkgName=
2023-05-30 12:10:45 : DEBUG : googledrive : choiceChangesXML=
2023-05-30 12:10:45 : DEBUG : googledrive : expectedTeamID=EQHXZ8M8AV
2023-05-30 12:10:45 : DEBUG : googledrive : blockingProcesses=Google Docs Google Drive Google Sheets Google Slides
2023-05-30 12:10:45 : DEBUG : googledrive : installerTool=
2023-05-30 12:10:45 : DEBUG : googledrive : CLIInstaller=
2023-05-30 12:10:45 : DEBUG : googledrive : CLIArguments=
2023-05-30 12:10:45 : DEBUG : googledrive : updateTool=
2023-05-30 12:10:45 : DEBUG : googledrive : updateToolArguments=
2023-05-30 12:10:45 : DEBUG : googledrive : updateToolRunAsCurrentUser=
2023-05-30 12:10:45 : INFO : googledrive : BLOCKING_PROCESS_ACTION=tell_user
2023-05-30 12:10:45 : INFO : googledrive : NOTIFY=success
2023-05-30 12:10:45 : INFO : googledrive : LOGGING=DEBUG
2023-05-30 12:10:45 : INFO : googledrive : LOGO=/System/Applications/App Store.app/Contents/Resources/AppIcon.icns
2023-05-30 12:10:45 : INFO : googledrive : Label type: pkgInDmg
2023-05-30 12:10:45 : INFO : googledrive : archiveName: Google Drive File Stream.dmg
2023-05-30 12:10:45 : DEBUG : googledrive : Changing directory to /Users/admin/Documents/GitHub/Installomator/build
2023-05-30 12:10:45 : INFO : googledrive : found packageID com.google.drivefs.arm64 installed, version 75.0.2.0
2023-05-30 12:10:45 : INFO : googledrive : appversion: 75.0.2.0
2023-05-30 12:10:45 : INFO : googledrive : Latest version of Google Drive File Stream is
2023-05-30 12:10:45 : INFO : googledrive : 75.0.2.0
2023-05-30 12:10:45 : REQ : googledrive : Downloading https://dl.google.com/drive-file-stream/GoogleDriveFileStream.dmg to Google Drive File Stream.dmg
2023-05-30 12:10:45 : DEBUG : googledrive : No Dialog connection, just download
2023-05-30 12:10:55 : DEBUG : googledrive : File list: -rw-r--r-- 1 root 2103187081 229M May 30 12:10 Google Drive File Stream.dmg
2023-05-30 12:10:55 : DEBUG : googledrive : File type: Google Drive File Stream.dmg: zlib compressed data
2023-05-30 12:10:55 : DEBUG : googledrive : curl output was:

  • Trying 142.250.217.110:443...
  • Connected to dl.google.com (142.250.217.110) port 443 (#0)
  • ALPN: offers h2,http/1.1
  • (304) (OUT), TLS handshake, Client hello (1):
    } [318 bytes data]
  • CAfile: /etc/ssl/cert.pem
  • CApath: none
  • (304) (IN), TLS handshake, Server hello (2):
    { [122 bytes data]
  • (304) (IN), TLS handshake, Unknown (8):
    { [15 bytes data]
  • (304) (IN), TLS handshake, Certificate (11):
    { [6486 bytes data]
  • (304) (IN), TLS handshake, CERT verify (15):
    { [79 bytes data]
  • (304) (IN), TLS handshake, Finished (20):
    { [36 bytes data]
  • (304) (OUT), TLS handshake, Finished (20):
    } [36 bytes data]
  • SSL connection using TLSv1.3 / AEAD-CHACHA20-POLY1305-SHA256
  • ALPN: server accepted h2
  • Server certificate:
  • subject: CN=*.google.com
  • start date: May 8 08:20:09 2023 GMT
  • expire date: Jul 31 08:20:08 2023 GMT
  • subjectAltName: host "dl.google.com" matched cert's "*.google.com"
  • issuer: C=US; O=Google Trust Services LLC; CN=GTS CA 1C3
  • SSL certificate verify ok.
  • using HTTP/2
  • h2h3 [:method: GET]
  • h2h3 [:path: /drive-file-stream/GoogleDriveFileStream.dmg]
  • h2h3 [:scheme: https]
  • h2h3 [:authority: dl.google.com]
  • h2h3 [user-agent: curl/7.88.1]
  • h2h3 [accept: /]
  • Using Stream ID: 1 (easy handle 0x149812400)

GET /drive-file-stream/GoogleDriveFileStream.dmg HTTP/2
Host: dl.google.com
user-agent: curl/7.88.1
accept: /

< HTTP/2 200
< accept-ranges: bytes
< content-disposition: attachment
< content-security-policy: default-src 'none'
< server: downloads
< x-content-type-options: nosniff
< x-frame-options: SAMEORIGIN
< x-xss-protection: 0
< date: Tue, 30 May 2023 19:10:45 GMT
< cache-control: public,max-age=0
< last-modified: Mon, 15 May 2023 23:57:24 GMT
< etag: "1628f48"
< content-type: application/x-apple-diskimage
< content-length: 240221632
< age: 0
< alt-svc: h3=":443"; ma=2592000,h3-29=":443"; ma=2592000 <
{ [1207 bytes data]

  • Connection #0 to host dl.google.com left intact

2023-05-30 12:10:55 : DEBUG : googledrive : DEBUG mode 1, not checking for blocking processes
2023-05-30 12:10:55 : REQ : googledrive : Installing Google Drive File Stream
2023-05-30 12:10:55 : INFO : googledrive : Mounting /Users/admin/Documents/GitHub/Installomator/build/Google Drive File Stream.dmg
2023-05-30 12:10:57 : DEBUG : googledrive : Debugging enabled, dmgmount output was:
Checksumming Driver Descriptor Map (DDM : 0)…
Driver Descriptor Map (DDM : 0): verified CRC32 $213ABB75
Checksumming Apple (Apple_partition_map : 1)…
Apple (Apple_partition_map : 1): verified CRC32 $1616107D
Checksumming DiscRecording 9.0.3d5 (Apple_HFS : 2)…
DiscRecording 9.0.3d5 (Apple_HFS : 2: verified CRC32 $D2C3CE98
Checksumming (Apple_Free : 3)…
(Apple_Free : 3): verified CRC32 $00000000
verified CRC32 $CE7F26CE
/dev/disk4 Apple_partition_scheme
/dev/disk4s1 Apple_partition_map
/dev/disk4s2 Apple_HFS /Volumes/Install Google Drive

2023-05-30 12:10:57 : INFO : googledrive : Mounted: /Volumes/Install Google Drive 2023-05-30 12:10:57 : DEBUG : googledrive : Found pkg(s): /Volumes/Install Google Drive/GoogleDrive.pkg
2023-05-30 12:10:57 : INFO : googledrive : found pkg: /Volumes/Install Google Drive/GoogleDrive.pkg 2023-05-30 12:10:57 : INFO : googledrive : Verifying: /Volumes/Install Google Drive/GoogleDrive.pkg
2023-05-30 12:10:57 : DEBUG : googledrive : File list: -rw-r--r-- 1 casper staff 228M May 15 16:38 /Volumes/Install Google Drive/GoogleDrive.pkg
2023-05-30 12:10:57 : DEBUG : googledrive : File type: /Volumes/Install Google Drive/GoogleDrive.pkg: xar archive compressed TOC: 6442, SHA-1 checksum
2023-05-30 12:10:57 : DEBUG : googledrive : spctlOut is /Volumes/Install Google Drive/GoogleDrive.pkg: accepted
2023-05-30 12:10:57 : DEBUG : googledrive : source=Notarized Developer ID
2023-05-30 12:10:57 : DEBUG : googledrive : origin=Developer ID Installer: Google LLC (EQHXZ8M8AV)
2023-05-30 12:10:57 : INFO : googledrive : Team ID: EQHXZ8M8AV (expected: EQHXZ8M8AV )
2023-05-30 12:10:57 : INFO : googledrive : Checking package version.
2023-05-30 12:10:57 : INFO : googledrive : Downloaded package com.google.drivefs.arm64 version 75.0.2.0
2023-05-30 12:10:57 : INFO : googledrive : Downloaded version of Google Drive File Stream is the same as installed.
2023-05-30 12:10:57 : DEBUG : googledrive : Unmounting /Volumes/Install Google Drive
2023-05-30 12:10:57 : DEBUG : googledrive : Debugging enabled, Unmounting output was:
"disk4" ejected.
2023-05-30 12:10:57 : DEBUG : googledrive : DEBUG mode 1, not reopening anything
2023-05-30 12:10:57 : REQ : googledrive : No new version to install
2023-05-30 12:10:57 : REQ : googledrive : ################## End Installomator, exit code 0

For issue #1062

I'm not sure if we /should/ do this, but this is effective to getting the version added to GoogleDrive. I could not find anything on Google's official sites to reference the full version numbers, but chocolatey.org does.

New Output:

sudo ./assemble.sh googledrive
2023-05-30 12:10:44 : REQ   : googledrive : ################## Start Installomator v. 10.4beta, date 2023-05-30
2023-05-30 12:10:44 : INFO  : googledrive : ################## Version: 10.4beta
2023-05-30 12:10:44 : INFO  : googledrive : ################## Date: 2023-05-30
2023-05-30 12:10:44 : INFO  : googledrive : ################## googledrive
2023-05-30 12:10:44 : DEBUG : googledrive : DEBUG mode 1 enabled.
2023-05-30 12:10:45 : DEBUG : googledrive : name=Google Drive File Stream
2023-05-30 12:10:45 : DEBUG : googledrive : appName=Google Drive.app
2023-05-30 12:10:45 : DEBUG : googledrive : type=pkgInDmg
2023-05-30 12:10:45 : DEBUG : googledrive : archiveName=
2023-05-30 12:10:45 : DEBUG : googledrive : downloadURL=https://dl.google.com/drive-file-stream/GoogleDriveFileStream.dmg
2023-05-30 12:10:45 : DEBUG : googledrive : curlOptions=
2023-05-30 12:10:45 : DEBUG : googledrive : appNewVersion=
2023-05-30 12:10:45 : DEBUG : googledrive : 75.0.2.0
2023-05-30 12:10:45 : DEBUG : googledrive : appCustomVersion function: Not defined
2023-05-30 12:10:45 : DEBUG : googledrive : versionKey=CFBundleShortVersionString
2023-05-30 12:10:45 : DEBUG : googledrive : packageID=com.google.drivefs.arm64
2023-05-30 12:10:45 : DEBUG : googledrive : pkgName=
2023-05-30 12:10:45 : DEBUG : googledrive : choiceChangesXML=
2023-05-30 12:10:45 : DEBUG : googledrive : expectedTeamID=EQHXZ8M8AV
2023-05-30 12:10:45 : DEBUG : googledrive : blockingProcesses=Google Docs Google Drive Google Sheets Google Slides
2023-05-30 12:10:45 : DEBUG : googledrive : installerTool=
2023-05-30 12:10:45 : DEBUG : googledrive : CLIInstaller=
2023-05-30 12:10:45 : DEBUG : googledrive : CLIArguments=
2023-05-30 12:10:45 : DEBUG : googledrive : updateTool=
2023-05-30 12:10:45 : DEBUG : googledrive : updateToolArguments=
2023-05-30 12:10:45 : DEBUG : googledrive : updateToolRunAsCurrentUser=
2023-05-30 12:10:45 : INFO  : googledrive : BLOCKING_PROCESS_ACTION=tell_user
2023-05-30 12:10:45 : INFO  : googledrive : NOTIFY=success
2023-05-30 12:10:45 : INFO  : googledrive : LOGGING=DEBUG
2023-05-30 12:10:45 : INFO  : googledrive : LOGO=/System/Applications/App Store.app/Contents/Resources/AppIcon.icns
2023-05-30 12:10:45 : INFO  : googledrive : Label type: pkgInDmg
2023-05-30 12:10:45 : INFO  : googledrive : archiveName: Google Drive File Stream.dmg
2023-05-30 12:10:45 : DEBUG : googledrive : Changing directory to /Users/admin/Documents/GitHub/Installomator/build
2023-05-30 12:10:45 : INFO  : googledrive : found packageID com.google.drivefs.arm64 installed, version 75.0.2.0
2023-05-30 12:10:45 : INFO  : googledrive : appversion: 75.0.2.0
2023-05-30 12:10:45 : INFO  : googledrive : Latest version of Google Drive File Stream is
2023-05-30 12:10:45 : INFO  : googledrive : 75.0.2.0
2023-05-30 12:10:45 : REQ   : googledrive : Downloading https://dl.google.com/drive-file-stream/GoogleDriveFileStream.dmg to Google Drive File Stream.dmg
2023-05-30 12:10:45 : DEBUG : googledrive : No Dialog connection, just download
2023-05-30 12:10:55 : DEBUG : googledrive : File list: -rw-r--r--  1 root  2103187081   229M May 30 12:10 Google Drive File Stream.dmg
2023-05-30 12:10:55 : DEBUG : googledrive : File type: Google Drive File Stream.dmg: zlib compressed data
2023-05-30 12:10:55 : DEBUG : googledrive : curl output was:
*   Trying 142.250.217.110:443...
* Connected to dl.google.com (142.250.217.110) port 443 (#0)
* ALPN: offers h2,http/1.1
* (304) (OUT), TLS handshake, Client hello (1):
} [318 bytes data]
*  CAfile: /etc/ssl/cert.pem
*  CApath: none
* (304) (IN), TLS handshake, Server hello (2):
{ [122 bytes data]
* (304) (IN), TLS handshake, Unknown (8):
{ [15 bytes data]
* (304) (IN), TLS handshake, Certificate (11):
{ [6486 bytes data]
* (304) (IN), TLS handshake, CERT verify (15):
{ [79 bytes data]
* (304) (IN), TLS handshake, Finished (20):
{ [36 bytes data]
* (304) (OUT), TLS handshake, Finished (20):
} [36 bytes data]
* SSL connection using TLSv1.3 / AEAD-CHACHA20-POLY1305-SHA256
* ALPN: server accepted h2
* Server certificate:
*  subject: CN=*.google.com
*  start date: May  8 08:20:09 2023 GMT
*  expire date: Jul 31 08:20:08 2023 GMT
*  subjectAltName: host "dl.google.com" matched cert's "*.google.com"
*  issuer: C=US; O=Google Trust Services LLC; CN=GTS CA 1C3
*  SSL certificate verify ok.
* using HTTP/2
* h2h3 [:method: GET]
* h2h3 [:path: /drive-file-stream/GoogleDriveFileStream.dmg]
* h2h3 [:scheme: https]
* h2h3 [:authority: dl.google.com]
* h2h3 [user-agent: curl/7.88.1]
* h2h3 [accept: */*]
* Using Stream ID: 1 (easy handle 0x149812400)
> GET /drive-file-stream/GoogleDriveFileStream.dmg HTTP/2
> Host: dl.google.com
> user-agent: curl/7.88.1
> accept: */*
>
< HTTP/2 200
< accept-ranges: bytes
< content-disposition: attachment
< content-security-policy: default-src 'none'
< server: downloads
< x-content-type-options: nosniff
< x-frame-options: SAMEORIGIN
< x-xss-protection: 0
< date: Tue, 30 May 2023 19:10:45 GMT
< cache-control: public,max-age=0
< last-modified: Mon, 15 May 2023 23:57:24 GMT
< etag: "1628f48"
< content-type: application/x-apple-diskimage
< content-length: 240221632
< age: 0
< alt-svc: h3=":443"; ma=2592000,h3-29=":443"; ma=2592000
<
{ [1207 bytes data]
* Connection #0 to host dl.google.com left intact

2023-05-30 12:10:55 : DEBUG : googledrive : DEBUG mode 1, not checking for blocking processes
2023-05-30 12:10:55 : REQ   : googledrive : Installing Google Drive File Stream
2023-05-30 12:10:55 : INFO  : googledrive : Mounting /Users/admin/Documents/GitHub/Installomator/build/Google Drive File Stream.dmg
2023-05-30 12:10:57 : DEBUG : googledrive : Debugging enabled, dmgmount output was:
Checksumming Driver Descriptor Map (DDM : 0)…
Driver Descriptor Map (DDM : 0): verified   CRC32 $213ABB75
Checksumming Apple (Apple_partition_map : 1)…
Apple (Apple_partition_map : 1): verified   CRC32 $1616107D
Checksumming DiscRecording 9.0.3d5 (Apple_HFS : 2)…
DiscRecording 9.0.3d5 (Apple_HFS : 2: verified   CRC32 $D2C3CE98
Checksumming  (Apple_Free : 3)…
(Apple_Free : 3): verified   CRC32 $00000000
verified   CRC32 $CE7F26CE
/dev/disk4          	Apple_partition_scheme
/dev/disk4s1        	Apple_partition_map
/dev/disk4s2        	Apple_HFS                      	/Volumes/Install Google Drive

2023-05-30 12:10:57 : INFO  : googledrive : Mounted: /Volumes/Install Google Drive
2023-05-30 12:10:57 : DEBUG : googledrive : Found pkg(s):
/Volumes/Install Google Drive/GoogleDrive.pkg
2023-05-30 12:10:57 : INFO  : googledrive : found pkg: /Volumes/Install Google Drive/GoogleDrive.pkg
2023-05-30 12:10:57 : INFO  : googledrive : Verifying: /Volumes/Install Google Drive/GoogleDrive.pkg
2023-05-30 12:10:57 : DEBUG : googledrive : File list: -rw-r--r--  1 casper  staff   228M May 15 16:38 /Volumes/Install Google Drive/GoogleDrive.pkg
2023-05-30 12:10:57 : DEBUG : googledrive : File type: /Volumes/Install Google Drive/GoogleDrive.pkg: xar archive compressed TOC: 6442, SHA-1 checksum
2023-05-30 12:10:57 : DEBUG : googledrive : spctlOut is /Volumes/Install Google Drive/GoogleDrive.pkg: accepted
2023-05-30 12:10:57 : DEBUG : googledrive : source=Notarized Developer ID
2023-05-30 12:10:57 : DEBUG : googledrive : origin=Developer ID Installer: Google LLC (EQHXZ8M8AV)
2023-05-30 12:10:57 : INFO  : googledrive : Team ID: EQHXZ8M8AV (expected: EQHXZ8M8AV )
2023-05-30 12:10:57 : INFO  : googledrive : Checking package version.
2023-05-30 12:10:57 : INFO  : googledrive : Downloaded package com.google.drivefs.arm64 version 75.0.2.0
2023-05-30 12:10:57 : INFO  : googledrive : Downloaded version of Google Drive File Stream is the same as installed.
2023-05-30 12:10:57 : DEBUG : googledrive : Unmounting /Volumes/Install Google Drive
2023-05-30 12:10:57 : DEBUG : googledrive : Debugging enabled, Unmounting output was:
"disk4" ejected.
2023-05-30 12:10:57 : DEBUG : googledrive : DEBUG mode 1, not reopening anything
2023-05-30 12:10:57 : REQ   : googledrive : No new version to install
2023-05-30 12:10:57 : REQ   : googledrive : ################## End Installomator, exit code 0
@scriptingosx scriptingosx added the version-check add or update version check label Jun 2, 2023
@scriptingosx scriptingosx added this to the v10.5 milestone Jun 2, 2023
@scriptingosx
Copy link
Collaborator

I appreciate the effort here but, yes, fetching the appNewVersion from an external source requires some discussion.

On the one hand, this probably wouldn't be less reliable than some of the strange HTML scarping we do for other labels. On the other, how certain are we that chocolatey.org updates this in a timely manner? Are we replacing one problem with a different one

@Theile @isaacatmann @acodega your thoughts?

Punting this to v10.5 until we decide...

@Theile
Copy link
Collaborator

Theile commented Jun 2, 2023

My thoughts are that we could also make Installomator download the latest release and check that for the version, before the script will ask the user to quit the app. So if appNewVersion is undefined we will download and check the downloaded version before asking for blocked processes.

@scriptingosx
Copy link
Collaborator

Thank you!

@scriptingosx scriptingosx merged commit d395fde into Installomator:main Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

version-check add or update version check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants