[CI] Use the latest LibCST source code in Pyre check#262
Merged
jimmylai merged 1 commit intoInstagram:masterfrom Mar 12, 2020
Merged
[CI] Use the latest LibCST source code in Pyre check#262jimmylai merged 1 commit intoInstagram:masterfrom
jimmylai merged 1 commit intoInstagram:masterfrom
Conversation
facebook-github-bot
added
the
CLA Signed
jimmylai
force-pushed
the
ci_use_libcst_source_in_pyre_check
branch
4 times, most recently
from
067c42b to
65dfe0b
Compare
jimmylai
force-pushed
the
ci_use_libcst_source_in_pyre_check
branch
2 times, most recently
from
2208d0e to
accc06f
Compare
Codecov Report
@@ Coverage Diff @@
## master #262 +/- ##
=======================================
Coverage 93.88% 93.88%
=======================================
Files 214 214
Lines 20818 20818
=======================================
Hits 19546 19546
Misses 1272 1272Continue to review full report at Codecov.
|
Contributor
|
Can you rename |
jimmylai
force-pushed
the
ci_use_libcst_source_in_pyre_check
branch
from
accc06f to
993e211
Compare
Contributor
Author
|
@thatch Renamed |
thatch
approved these changes
Mar 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After we ask pyre to read site-packages, Pyre cannot understand new changes in LibCST repo..
CI installs pyre-check from pip requirements which installs the public version of libcst.
This removes the installed libcst and install from the checked out repo.
Test Plan
CI build.