BUG: Wrap MetaDataObject for Array and std::vector value types#2270
Merged
dzenanz merged 1 commit intoInsightSoftwareConsortium:masterfrom Jan 27, 2021
Merged
Conversation
These are other commonly used types, e.g. when "NRRD_measurement frame" is set. Addresses: Project-MONAI/MONAI#1451
thewtex
force-pushed
the
wrap-nrrd-measurement-frame
branch
from
2287d88 to
e7c72d1
Compare
aylward
approved these changes
Jan 27, 2021
Member
aylward
left a comment
aylward
left a comment
There was a problem hiding this comment.
LGTM!!! Nice wrapping system, makes these changes seem intuitive.
dzenanz
approved these changes
Jan 27, 2021
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are other commonly used types, e.g. when "NRRD_measurement frame"
is set.
Addresses: Project-MONAI/MONAI#1451