Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes scope resolution issues in Koin's dependency injection framework, addressing issue #2274. The changes focus on improving how scoped instances are resolved when using custom scope linking patterns, particularly when scopes are unlinked from the root scope and linked to other scopes.
Key Changes:
- Modified scope resolution logic to support chained parent scope lookup when a single scope is linked
- Changed scope archetype check to use
scopeArchetype == nullinstead ofTypeQualifiercheck - Added exception handling for
MissingScopeValueExceptionto gracefully handle missing scoped values
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
projects/core/koin-core/src/commonTest/kotlin/org/koin/core/ScopeTest.kt |
Added two regression tests demonstrating scope resolution through custom-linked scopes |
projects/core/koin-core/src/commonMain/kotlin/org/koin/core/resolution/CoreResolver.kt |
Modified parent scope resolution to support chained lookup for single-linked scopes and updated archetype condition |
projects/core/koin-core/src/commonMain/kotlin/org/koin/core/registry/InstanceRegistry.kt |
Added exception handling for MissingScopeValueException and sorting for deterministic instance retrieval |
projects/core/koin-core/src/commonMain/kotlin/org/koin/core/instance/ScopedInstanceFactory.kt |
Enhanced isCreated() logic and added exception throwing for non-holdInstance factories |
projects/compose/koin-compose-navigation3/build.gradle.kts |
Changed minSdk from property reference to hardcoded value 23 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
projects/core/koin-core/src/commonMain/kotlin/org/koin/core/registry/InstanceRegistry.kt
Show resolved
Hide resolved
projects/core/koin-core/src/commonMain/kotlin/org/koin/core/resolution/CoreResolver.kt
Show resolved
Hide resolved
projects/core/koin-core/src/commonTest/kotlin/org/koin/core/ScopeTest.kt
Show resolved
Hide resolved
projects/core/koin-core/src/commonMain/kotlin/org/koin/core/resolution/CoreResolver.kt
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix scope resolution issues for #2274