Merged
Conversation
… and others). Upgrade Nav3 to stable 1.0.0
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for passing metadata to navigation entries in the Koin Navigation 3 integration and upgrades the androidx.navigation3 dependency from beta (1.0.0-beta01) to stable (1.0.0). The metadata parameter enables users to configure navigation animations and other navigation-specific settings (like NavDisplay.transitionSpec) directly in the navigation entry declarations.
- Added optional
metadataparameter to bothScopeDSL.navigation()andModule.navigation()functions - Upgraded androidx.navigation3 dependency to stable version 1.0.0
- Updated KDoc documentation to describe the new metadata parameter
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| projects/gradle/libs.versions.toml | Upgraded androidx-navigation3 from 1.0.0-beta01 to stable 1.0.0 |
| projects/compose/koin-compose-navigation3/src/commonMain/kotlin/org/koin/dsl/navigation3/ModuleExt.kt | Added metadata parameter to both navigation function overloads with proper pass-through to entry() calls and updated documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow metadata parameter passing to the entry point (like animations and others).
Upgrade Nav3 to stable 1.0.0
Updated in
navigation<T>(metadata = <>){ /* Composable */ }