Add optional navGraphRoute parameter to sharedKoinViewModel for flexible navigation graph resolution#2262
Merged
arnaudgiuliani merged 1 commit intoInsertKoinIO:4.1.1from Sep 2, 2025
Conversation
…ter to sharedKoinViewModel
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces an overload for sharedKoinViewModel to allow an optional navGraphRoute parameter.
Motivation
The current implementation relies on destination.parent?.route which works for simple hierarchies. In more complex navigation setups (nested graphs, sibling graphs, multi-level NavHost), developers may need explicit control over which NavBackStackEntry to use.
Changes
• Added navGraphRoute parameter with default this.destination.parent?.route.
• Fallback to default koinViewModel() if navGraphRoute is null.
Example Usage
This improves flexibility without breaking existing API.