[Maintenance] Cleanup of examples#2213
Merged
arnaudgiuliani merged 3 commits intoInsertKoinIO:4.2.0from Nov 21, 2025
Merged
Conversation
GrzegorzBobryk
force-pushed
the
maintenance/cleanup-of-examples
branch
from
29a2d6c to
b896d70
Compare
GrzegorzBobryk
force-pushed
the
maintenance/cleanup-of-examples
branch
from
b896d70 to
8f49f34
Compare
- fixed `koin_version`; - `compileOptions` fixed; - `jvmTarget` taken from `JavaVersion`; - warning for `resources.getColor` fixed; - `examples.jvm-prefs` fixed and added `koin_version` from versions file; - usage of `flatten` marked as internal fixed; - fix for setting jvm in kts.
- junit is always taking `junit_version`; - `kotlinOptions.jvmTarget` migrated to `kotlin.compilerOptions.jvmTarget`;
GrzegorzBobryk
force-pushed
the
maintenance/cleanup-of-examples
branch
from
8f49f34 to
79a279f
Compare
- fix for changed `module` to `lazyModule`
| @Test | ||
| fun `Verify Module Configuration`() { | ||
| appModules.verify(extraTypes = androidTypes) | ||
| mainModules.value.verify(extraTypes = androidTypes) |
Member
There was a problem hiding this comment.
yes, I forgot to manage it back 👍
arnaudgiuliani
approved these changes
Nov 21, 2025
Member
arnaudgiuliani
left a comment
arnaudgiuliani
left a comment
There was a problem hiding this comment.
Thanks @GrzegorzBobryk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
koin_version;compileOptionsfixed;jvmTargettaken fromJavaVersion;resources.getColorfixed;examples.jvm-prefsfixed and addedkoin_versionfrom versions file;flattenmarked as internal fixed.