Skip to content

Fix several issues #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
imeoer merged 9 commits into from
Jan 31, 2023
Merged

Fix several issues #137

imeoer merged 9 commits into from
Jan 31, 2023

Conversation

@w568w
Copy link
Contributor

@w568w w568w commented Jan 31, 2023 •
edited
Loading

This PR will close some old issues. 🚧

  1. Fix site下新建变量后会导致文章生成错误 #112;
  2. Fix chole.io still part of this project? #133;
  3. Fix the keyword highlighting, which would break non-text DOM nodes;
  4. Append previously approved themes to README (i.e. close 新的使用者，以及一个Material Design风格主题 #123 and close 捣鼓了个主题 #111);
  5. Support footnote syntax (fix 似乎没法使用Markdown的注释？ #21).

imeoer
imeoer reviewed Jan 31, 2023
View reviewed changes
@imeoer
Copy link
Member

imeoer commented Jan 31, 2023

很赞的 PR，commit 拆分清晰

imeoer
imeoer approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@imeoer imeoer merged commit eaf0299 into InkProject:master Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@imeoer imeoer imeoer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

2 participants

@w568w @imeoer