Skip to content

Conversation

@popcornylu
Copy link
Collaborator

@popcornylu popcornylu commented Apr 20, 2023

  • Add the statuses seed.
  • In the orders model, add the status_str to show the order status in a human-readable format.

image

We found the unexpected metric change.
image

It's due to wrong join. It should be left join rather than inner join.
https://github.com/InfuseAI/jaffle_shop/pull/19/files#diff-b19a7fe874c022775e17dd755f65e1fe34da1317c8ac7a1a49c3286f0f4b3f21L19

@github-actions

This comment was marked as outdated.

@popcornylu

This comment was marked as outdated.

@popcornylu popcornylu changed the title Add the order status table [Demo] Add the order status table. (don't merge me) Apr 26, 2023
@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@popcornylu

This comment was marked as outdated.

@popcornylu

This comment was marked as outdated.

@wcchang1115 wcchang1115 force-pushed the feature/sc-31094/add-seed-status branch from c6bb901 to 63c9c79 Compare July 26, 2023 03:33
@github-actions

This comment was marked as outdated.

@wcchang1115 wcchang1115 force-pushed the feature/sc-31094/add-seed-status branch from f3b936d to fb2c7d3 Compare August 3, 2023 07:48
@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

Signed-off-by: popcorny <[email protected]>
Co-authored-by: wcchang <[email protected]>
@wcchang1115 wcchang1115 force-pushed the feature/sc-31094/add-seed-status branch from fb2c7d3 to c06e52e Compare September 7, 2023 08:09
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

📊 Piperider Comparison Summary

Impact Summary

PipeRider Report

Code Changes

Added Removed Modified
2 0 1

Resource Impact

Potentially Impacted Assessed Impacted
3 3 assessed, 0 skipped 1

Resource Impact

Models

    Model Impact Columns
Rows Dbt Time Failed Tests All Tests
..els/staging/stg_statuses.sql Assessed not impacted 2 4 0:00:00.04 - -
models/marts/orders.sql Impacted 16 ($\color{green}{\text{ 1 }}$ / $\color{red}{\text{ 0 }}$ / $\color{orange}{\text{ 15 }}$) 97 $\color{orange}{\text{ (↓ -2) }}$ 0:00:00.06 $\color{red}{\text{ (↑ 0.01) }}$ 0 9

Metrics

No changes detected

📎 Generated Comparison Report ZIP

Find it in the Github Action Runs Page

@popcornylu popcornylu changed the title [Demo] Add the order status table. (don't merge me) [Demo] Add the order status table Sep 7, 2023
@github-actions
Copy link

📊 Piperider Comparison Summary

Impact Summary

PipeRider Report

Code Changes

Added Removed Modified
2 0 1

Resource Impact

Potentially Impacted Assessed Impacted
3 3 assessed, 0 skipped 1

Resource Impact

Models

    Model Impact Columns
Rows Dbt Time Failed Tests All Tests
..els/staging/stg_statuses.sql Assessed not impacted 2 4 0:00:00.09 - -
models/marts/orders.sql Impacted 16 ($\color{green}{\text{ 1 }}$ / $\color{red}{\text{ 0 }}$ / $\color{orange}{\text{ 15 }}$) 97 $\color{orange}{\text{ (↓ -2) }}$ 0:00:00.09 $\color{red}{\text{ (↑ 0.03) }}$ 0 9

Metrics

No changes detected

📎 Generated Comparison Report ZIP

Find it in the Github Action Runs Page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants