feat(pki): add IP address SAN support to ACME certificate issuance#5771
feat(pki): add IP address SAN support to ACME certificate issuance#5771saifsmailbox98 merged 6 commits intomainfrom
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Greptile SummaryThis PR extends Infisical's ACME certificate issuance to support IP address identifiers (RFC 8738), unblocking the use case where the underlying CA already supports IP SANs but the ACME layer was rejecting them. The changes span identifier validation, challenge type selection (HTTP-01 only for IP), CSR matching, and IPv6 URL construction. Key changes:
Issues found:
Confidence Score: 2/5
Important Files Changed
|
7361c8e to
cf0a15c
Compare
cf0a15c to
5b1e16a
Compare
Context
ACME certificate issuance rejected IP address identifiers with "Only DNS identifiers are supported."
The underlying CA infrastructure already supported IP SANs - only the ACME layer was blocking them.
Fixes #5550
Steps to verify the change
Type
Checklist
type(scope): short description(scope is optional, e.g.,fix: prevent crash on syncorfix(api): handle null response).