Skip to content

fix(helm): streamline Cloudsmith CLI installation in helm gateway workflow#5758

Merged
victorvhs017 merged 1 commit intomainfrom
fix/update-gateway-helm-chart-release-action-for-oci
Mar 19, 2026
Merged

fix(helm): streamline Cloudsmith CLI installation in helm gateway workflow#5758
victorvhs017 merged 1 commit intomainfrom
fix/update-gateway-helm-chart-release-action-for-oci

Conversation

@victorvhs017
Copy link
Copy Markdown
Contributor

Context

Follow up for this task #5729. We need to update the workflow to pass the username.

Type

  • Fix
  • Feature
  • Improvement
  • Breaking
  • Docs
  • Chore

Checklist

  • Title follows the conventional commit format: type(scope): short description (scope is optional, e.g., fix: prevent crash on sync or fix(api): handle null response).
  • Tested locally
  • Updated docs (if needed)
  • Updated CLAUDE.md files (if needed)
  • Read the contributing guide

@maidul98
Copy link
Copy Markdown
Collaborator

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Mar 19, 2026

Greptile Summary

This PR streamlines the release-helm job in .github/workflows/release_helm_gateway.yaml by removing two now-unnecessary steps (Python setup and cloudsmith-cli pip install) and adds the missing CLOUDSMITH_USERNAME secret as an environment variable.

  • Correct removal of Python/Cloudsmith CLI steps: helm-charts/upload-gateway-cloudsmith.sh exclusively uses helm registry login / helm push via OCI, so the cloudsmith-cli was never invoked — removing those steps is correct.
  • Critical fix: CLOUDSMITH_USERNAME is required by the upload script (which exits early with an error if it is absent) but was not previously passed into the workflow step, making every prior release invocation fail at the env-variable guard.
  • No issues identified: Both secrets are referenced via ${{ secrets.CLOUDSMITH_API_KEY }} and ${{ secrets.CLOUDSMITH_USERNAME }}, which is the correct pattern. Ensure the CLOUDSMITH_USERNAME secret has been added to the repository/org secrets before running this workflow.

Confidence Score: 5/5

  • This PR is safe to merge; it removes dead code and adds a missing required secret reference.
  • The change is minimal and correct: the Cloudsmith CLI was never used by the upload script (which relies on native helm OCI commands), and CLOUDSMITH_USERNAME was provably missing from the env block, causing every workflow run to fail at the script's own validation guard. No logic errors or security concerns introduced.
  • No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/release_helm_gateway.yaml Removes unused Python/Cloudsmith CLI installation steps and adds the missing CLOUDSMITH_USERNAME secret as an env var. The upload script uses helm OCI commands directly, making the CLI steps unnecessary. Adding CLOUDSMITH_USERNAME fixes the script's early-exit guard.

Last reviewed commit: "chore: streamline Cl..."

@victorvhs017 victorvhs017 merged commit de9c7eb into main Mar 19, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants