improvement: platfrm-184 update bullmq version for jobScheduler#5723
improvement: platfrm-184 update bullmq version for jobScheduler#5723PrestigePvP merged 7 commits intomainfrom
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Greptile SummaryThis PR upgrades BullMQ from
Confidence Score: 2/5
Important Files Changed
Last reviewed commit: 402ece2 |
c9f14ff to
a646e81
Compare
victorvhs017
left a comment
There was a problem hiding this comment.
When I run the app, I get:
You can replicate by creating a secret rotation on main and then checking out this branch.
The issue here is that even though we stop the repeatable job creator, it may have already created the next job and put it in the queue.
And because our job scheduler uses the same id in its jobs, it won't be able to produce the next job while this one is not executed.
I see two options here:
- Remove the repeatable jobs (what you've done) AND any job created by it from the queue
- Change the id for the scheduler jobs. This would fix the issue with one drawback: the next job would be executed twice (the remaining job from the repeatable jobs producer + the new job from the new scheduler).
Looking at the queues, it shouldn't be an issue to execute this twice, only once. The biggest impact would be one duplicated email and a couple of duplicated notifications. But it's good to test if the old job id is completely gone from Redis after that.
c378b95 to
45a5fd9
Compare
No description provided.