improvement(pki): add RBAC policy conditions for certificate metadata#5697
Conversation
…tead of comma-separated string
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Greptile SummaryThis PR extends certificate RBAC by adding Key changes and findings:
Confidence Score: 3/5
Important Files Changed
|
|
@greptile re-review this PR |
|
@greptile
|
|
Fair points on 2-4. If this follows existing patterns across the codebase, that makes sense. On point 1 though: While UUID enumeration is indeed hard, the information disclosure concern isn't about brute-forcing UUIDs — it's about what happens when someone does have a valid UUID (from logs, URLs, error messages, etc.). The original ordering prevented distinguishing "doesn't exist" from "you can't access it," which is a deliberate security pattern. If you need metadata for RBAC and this reordering is unavoidable, consider the two-stage check I suggested: a lightweight permission guard before the fetch (general But if this pattern is already used for other entities and you've assessed the risk, I'll defer to that architectural decision. |
Context
Adds metadata as an RBAC condition for certificates
Screenshots
Steps to verify the change
Type
Checklist
type(scope): short description(scope is optional, e.g.,fix: prevent crash on syncorfix(api): handle null response).