improvement: Add project name to secret approval notifications#5586
Merged
akhilmhdh merged 1 commit intoInfisical:mainfrom Mar 25, 2026
Merged
improvement: Add project name to secret approval notifications#5586akhilmhdh merged 1 commit intoInfisical:mainfrom
akhilmhdh merged 1 commit intoInfisical:mainfrom
Conversation
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
Greptile SummaryThis PR adds
Confidence Score: 4/5
Important Files Changed
Last reviewed commit: 7540d80 |
backend/src/ee/services/secret-approval-request/secret-approval-request-service.ts
Show resolved
Hide resolved
akhilmhdh
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Secret approval request notifications (Slack, Teams) didn't include the project name, making it hard to tell which project the request belongs to when you have multiple projects using one channel. Added
projectNameto the notification payload so it shows alongside environment, secret path, and secret keys.Steps to verify the change
Type
Checklist
type(scope): short description(scope is optional, e.g.,fix: prevent crash on syncorfix(api): handle null response).