Repository navigation
Reject evidence from multiple studies in Key Object Selection Documents - #503
Merged
CPBridge merged 1 commit intoNov 2, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #502
KeyObjectSelectionDocument.__init__is meant to raise aValueErrorwhen the provided evidence spans more than one study, since the Key Object Document Module requires the Current Requested Procedure Evidence Sequence (Type 1) to list every instance referenced in the content and referencing more than one study additionally requires the Identical Documents Sequence, which highdicom does not create.Since #373 split the collected evidence into same-study and other-study items, the guard has compared the number of other studies against
1instead of0. With evidence from exactly two studies no error is raised, the other-study instances are silently dropped from the evidence sequence, and the resulting document references SOP instances that are not listed in the Current Requested Procedure Evidence Sequence.resolve_reference()then fails for those instances.Changes:
ValueErrorwhenever any other-study evidence is collected, and set the Current Requested Procedure Evidence Sequence unconditionally (it is Type 1 and the first evidence item always belongs to the document's study).Tests:
pytest tests/test_ko.py tests/test_sr.py(344 passed);flake8 src/highdicom/ko/sop.py tests/test_ko.pyandmypy src/highdicom/ko/sop.pyare clean.