Skip to content

Change to definition of SR evidence - #373

Merged
CPBridge merged 7 commits into
masterfrom
bug/sr_evidence
Aug 25, 2025
Merged

CPBridge merged 7 commits into
masterfrom
bug/sr_evidence

Conversation

@CPBridge

@CPBridge CPBridge commented Aug 22, 2025 •

Copy link
Copy Markdown
Collaborator

Fixes for issues related to SR from @deepakri201 's conversion project:

  • Replace use of pydicom.sr.coding.codes.SCT.Source with a manual code to remove the unwanted "(attribute)" part of the meaning string. Also fix some outdated codes found in doc pages
  • Change the behavior of the highdicom.sr.utils.collect_evidence function in regard to how it determines which evidence goes in the CurrentRequestProcedureEvidenceSequence and which into the PertinentOtherEvidenceSequence. Previously this was based on whether the item is found in the SR content tree. Now it is based on whether the item belongs to the same study as the new SR document.

@CPBridge CPBridge self-assigned this Aug 22, 2025
@CPBridge CPBridge added the bug Something isn't working label Aug 22, 2025
@CPBridge
CPBridge marked this pull request as ready for review August 22, 2025 18:59
@fedorov

fedorov commented Aug 22, 2025

Copy link
Copy Markdown
Member

Replace use of pydicom.sr.coding.codes.SCT.Source with a manual code

@CPBridge why not try to fix it in pydicom?

And on that note, do you know if pydicom is taking those from here: https://dicom.nema.org/medical/dicom/current/output/chtml/part16/chapter_O.html ? Since in that table most of the items have the unwanted qualifiers ...

@CPBridge

Copy link
Copy Markdown
Collaborator Author

Yes I plan to, but that will be a bigger undertaking and pydicom has a much slower release cycle than highdicom. So this is a quick fix for the short term.

There are other issues with pydicom's code, including some errors in the UCUM codes that I found a few weeks ago.

I'm not that familiar with how they generate the code tables and would have to look into it, but I suspect you might be right about that table

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants