Switch to gi Atspi, and work on waiting for document:load-complete#3
Merged
spectranaut merged 6 commits intoacacia-test-testdriverfrom May 21, 2024
Merged
Switch to gi Atspi, and work on waiting for document:load-complete#3spectranaut merged 6 commits intoacacia-test-testdriverfrom
document:load-complete#3spectranaut merged 6 commits intoacacia-test-testdriverfrom
Conversation
spectranaut
force-pushed
the
switch-gi-atspi
branch
2 times, most recently
from
75b12ed to
a35ffea
Compare
schenney-chromium
pushed a commit
that referenced
this pull request
Jul 15, 2024
Since @page border box layout objects aren't in the the layout tree, any code that wants to walk up the tree to find the containing block will be in for a surprise. This would happen if percentage-based @page padding was used [1]. Recomputing padding during painting when we have already done it during layout is rather pointless anyway. Read it out directly from the fragment. [1] #1 blink::LayoutBox::ContainingBlockLogicalWidthForContent() #2 blink::LayoutBoxModelObject::ComputedCSSPadding() #3 blink::LayoutBoxModelObject::PaddingTop() #4 blink::LayoutBoxModelObject::PaddingOutsets() #5 blink::BoxPainterBase::PaintFillLayer() #6 blink::BoxPainterBase::PaintFillLayers() #7 blink::BoxFragmentPainter::PaintBackground() Bug: 40286153 Change-Id: I1e6e92c2ce1d81aab2673ec9a877eac455534102 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5526469 Commit-Queue: Morten Stenshorne <[email protected]> Reviewed-by: Xianzhu Wang <[email protected]> Reviewed-by: Ian Kilpatrick <[email protected]> Cr-Commit-Position: refs/heads/main@{#1300711}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So the diff here is a hard to look at, but here is the file on the branch: https://github.com/Igalia/wpt/blob/a53e36e604db76a6166626c418903d4eef4f631c/tools/wptrunner/wptrunner/executors/executoracacia.py
Eventually, we will have to handle multiple tests execute in row, we will have to wait for the new test page to be loaded as well. To do this we need to know the title of the test page, which might mean some more data plumbing from the test harness to this part of execution logic.