Conversation
lippserd
requested changes
Apr 25, 2025
| $parents = $this->listParentUuidsFor($uuid); | ||
| $parents[] = $uuid; | ||
| $parents = [$uuid]; | ||
| array_push($parents, ...$this->listParentUuidsFor($uuid)); |
Member
There was a problem hiding this comment.
With #572 (PHP 7.4) you can do the following:
$parents = [$uuid, ...$this->listParentUuidsFor($uuid)];Just for the records, without PHP 7.4, I would've opted for the following:
$parents = $this->listParentUuidsFor($uuid);
array_unshift($parents, $uuid);
jrauh01
force-pushed
the
fix-leaf-rule-bug
branch
from
229fe56 to
2225d04
Compare
The uuid of the nearest parent was checked last but had to be checked first. This resulted in a bug that caused the monitoring rules of the leaf notes to be overwritten by those of the parents.
jrauh01
force-pushed
the
fix-leaf-rule-bug
branch
from
2225d04 to
8bddc36
Compare
lippserd
approved these changes
Apr 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The uuid of the nearest parent was checked last but had to be checked first. This resulted in a bug that caused the monitoring rules of the leaf notes to be overwritten by those of the parents.
Fixes #527