Skip to content

Fix db type error, when hostgroup is accidentially interpreted as integer#2822

Merged
Thomas-Gelf merged 1 commit intoIcinga:masterfrom
cschra:bugfix/allow-hostgroup-integer
Oct 19, 2023
Merged

Fix db type error, when hostgroup is accidentially interpreted as integer#2822
Thomas-Gelf merged 1 commit intoIcinga:masterfrom
cschra:bugfix/allow-hostgroup-integer

Conversation

@cschra
Copy link
Copy Markdown
Contributor

@cschra cschra commented Oct 19, 2023

fixes #2821

@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Oct 19, 2023

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @cschra

Details
  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

@bobapple
Copy link
Copy Markdown
Member

The signed CLA is missing one or more GitHub usernames.

@cschra
Copy link
Copy Markdown
Contributor Author

cschra commented Oct 19, 2023

The signed CLA is missing one or more GitHub usernames.

sorry for the inconvinience, I submitted a new one

@cschra cschra force-pushed the bugfix/allow-hostgroup-integer branch from 785648b to 917d62a Compare October 19, 2023 11:35
@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Oct 19, 2023

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @cschra

Details
  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

@cschra cschra force-pushed the bugfix/allow-hostgroup-integer branch from 917d62a to 8590cea Compare October 19, 2023 11:37
@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Oct 19, 2023

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @cschra

Details
  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

@bobapple
Copy link
Copy Markdown
Member

@cla-bot check

@cla-bot cla-bot bot added the cla/signed label Oct 19, 2023
@Thomas-Gelf
Copy link
Copy Markdown
Contributor

Please remove the superfluous indentation character on all three lines, to address Code Sniffer complaints. Then this is ready to be merged.

@cschra cschra force-pushed the bugfix/allow-hostgroup-integer branch from 8590cea to d9070ec Compare October 19, 2023 12:45
@cschra
Copy link
Copy Markdown
Contributor Author

cschra commented Oct 19, 2023

Please remove the superfluous indentation character on all three lines, to address Code Sniffer complaints. Then this is ready to be merged.

done

@Thomas-Gelf Thomas-Gelf merged commit aa31b37 into Icinga:master Oct 19, 2023
@Thomas-Gelf
Copy link
Copy Markdown
Contributor

Merged, thank you!

@Thomas-Gelf Thomas-Gelf added this to the v1.12.0 milestone Oct 19, 2023
@nilmerg nilmerg modified the milestones: v1.12.0, v1.11.1 Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

icinga hostgroup object_name interpretet as integer causes postgres error

4 participants