Skip to content

Downtime: Add parent_id#323

Merged
lippserd merged 1 commit intomasterfrom
feature/downtime-parent-downtime-id
Aug 9, 2021
Merged

Downtime: Add parent_id#323
lippserd merged 1 commit intomasterfrom
feature/downtime-parent-downtime-id

Conversation

@N-o-X
Copy link
Copy Markdown
Contributor

@N-o-X N-o-X commented Jul 22, 2021 •
edited by lippserd
Loading

This PR adds the downtime attribute parent_id added to Icinga 2 with Icinga/icinga2#8913 to Icinga DB.

resolves #258

@N-o-X N-o-X added this to the v1.0.0-rc2 milestone Jul 22, 2021
@N-o-X N-o-X mentioned this pull request Jul 22, 2021
Merged
@N-o-X N-o-X requested a review from lippserd July 22, 2021 15:51
@N-o-X N-o-X marked this pull request as ready for review July 22, 2021 15:51
@lippserd
Copy link
Copy Markdown
Member

lippserd commented Jul 22, 2021

Also with # 301 in mind, are trigger_by_id, parent_downtime_id and scheduled_by mutually exclusive or could two or all of them be set?

@lippserd lippserd added the needs-feedback We'll only proceed once we hear from you again label Jul 22, 2021
@N-o-X N-o-X changed the title Downtime: Add parent_downtime_id Downtime: Add parent_id Jul 23, 2021
@N-o-X N-o-X force-pushed the feature/downtime-parent-downtime-id branch from 35054d7 to 9f6c73c Compare July 23, 2021 11:54
@N-o-X
Copy link
Copy Markdown
Contributor Author

N-o-X commented Jul 23, 2021

As we already found out in our meeting a few hours ago, trigger_by_id and scheduled_by will both be set, when using child_options in a ScheduledDowntime.

@N-o-X N-o-X removed the needs-feedback We'll only proceed once we hear from you again label Jul 23, 2021
@N-o-X N-o-X removed their assignment Jul 23, 2021
lippserd
lippserd requested changes Aug 3, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@lippserd lippserd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if the other columns don't have a meaningful comment at the moment, it would be good if the comment for parent_id describes what the column represents.

@N-o-X
Copy link
Copy Markdown
Contributor Author

N-o-X commented Aug 9, 2021

Even if the other columns don't have a meaningful comment at the moment, it would be good if the comment for parent_id describes what the column represents.

I'd create a separate PR to add descriptions for all 3 columns.

@N-o-X N-o-X requested a review from lippserd August 9, 2021 11:32
@N-o-X
Copy link
Copy Markdown
Contributor Author

N-o-X commented Aug 9, 2021

@cla-bot check

@cla-bot cla-bot bot added the cla/signed label Aug 9, 2021
@lippserd lippserd merged commit 783b3a6 into master Aug 9, 2021
@lippserd lippserd deleted the feature/downtime-parent-downtime-id branch August 9, 2021 11:43
@lippserd lippserd mentioned this pull request Aug 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lippserd lippserd lippserd approved these changes

Assignees

No one assigned

Labels

area/configsync area/history area/schema cla/signed enhancement New feature or request

Projects

None yet

Milestone

1.0.0-rc2

Development

Successfully merging this pull request may close these issues.

A downtime scheduled per API with all_services should be identifiable by the resulting service downtimes

2 participants

@N-o-X @lippserd