Remove dead code in GetSignatureAlgorithm()#9882
Remove dead code in GetSignatureAlgorithm()#9882julianbrost merged 1 commit intoIcinga:masterfrom botovq:tlsutility/remove-dead-code
Conversation
|
Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA). Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA. After that, please reply here with a comment and we'll verify. Contributors that have not signed yet: @botovq Details
|
This code was added in commit 548eb93 and never did anything useful. Using X509_get_signature_nid() or its expanded version in the pre-1.1 branch is the correct way of retrieving the signature algorithm of a certificate. CLA: trivial
|
Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA). Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA. After that, please reply here with a comment and we'll verify. Contributors that have not signed yet: @botovq Details
|
|
Hello Theo and thanks for contributing! You have force-pushed an identical commit after the bot's comment #9882 (comment). This doesn't harm, but also does nothing useful. At least the bot is still not aware of the signature (#9882 (comment)).
If you've already followed those instructions...
... just say so in the comments (here) and we'll verify. Best, |
|
|
||
| X509_PUBKEY_get0_param(nullptr, nullptr, 0, &algor, key); //TODO: Error handling | ||
|
|
||
| alg = OBJ_obj2nid (algor->algorithm); |
There was a problem hiding this comment.
Indeed, all of this is very nice... but doesn't do anything useful.
Al2Klimov
added
the
core/quality
|
On Mon, Oct 23, 2023 at 02:08:43AM -0700, Alexander Aleksandrovič Klimov wrote:
Hello Theo and thanks for contributing!
You have force-pushed [an identical commit](https://github.com/Icinga/icinga2/compare/07ee13d4f5a3cd7fab59cf44573da4fcdff62d07..1f06589f7afeed119b041ca62d745063e600b1a6) after the bot's comment #9882 (comment). This doesn't harm, but also does nothing useful. At least the bot is still not aware of the signature (#9882 (comment)).
Yes. I was trying to add a CLA: trivial in hopes of appeasing the bot.
> After that, please reply here with a comment and we'll verify.
... just say so in the comments (here) and we'll verify.
I have done so, covering the address of that commit.
May I suggest that you make the requirement of a CLA visible in
CONTRIBUTING.md? It always takes quite a bit of time to deal with this
annoyance and I would have preferred to deal with that another time...
|
|
@cla-bot check |
4 participants
This code was added in commit 548eb93 and never did anything useful. Using X509_get_signature_nid() or its expanded version in the pre-1.1 branch is the correct way of retrieving the signature algorithm of a certificate.