check_ssl_cert: integrate new option to set maximum validity#9881
Merged
Al2Klimov merged 5 commits intoIcinga:masterfrom May 27, 2024
Merged
Conversation
Al2Klimov
requested changes
Oct 23, 2023
Member
Al2Klimov
left a comment
Al2Klimov
left a comment
There was a problem hiding this comment.
Please also update the documentation.
Al2Klimov
requested changes
Jan 3, 2024
Member
Al2Klimov
left a comment
Al2Klimov
left a comment
There was a problem hiding this comment.
Please undo the master merge via:
git reset --hard 6fc8bb611b60673a9a2a913d08e77a6a33dced07git push -f
cycloon
force-pushed
the
feature/check-ssl-cert-maximum-validity
branch
from
f39e964 to
6fc8bb6
Compare
Contributor
Author
|
Sorry, I just did not see the notification for this PR. I did what you suggested. Please let me know if that is still okay or if I can do anything else. |
Al2Klimov
requested changes
Jan 22, 2024
Member
Al2Klimov
left a comment
Al2Klimov
left a comment
There was a problem hiding this comment.
I meant the ITL documentation under doc/
Al2Klimov
requested changes
Jan 26, 2024
Al2Klimov
previously approved these changes
Jan 26, 2024
Member
Al2Klimov
left a comment
Al2Klimov
left a comment
There was a problem hiding this comment.
Note
Despite, technically speaking, multiple committers this PR may (and should) be squashed during merge.
check_ssl_cert has a new option with a new default: --maximum-validity. This change allows for services to use that option to override the default of 397 days. It is needed, if you have internal certificates that have a longer duration.
Update documentation as requested
Al2Klimov
force-pushed
the
feature/check-ssl-cert-maximum-validity
branch
from
ae8044c to
d41b3f0
Compare
Al2Klimov
requested changes
May 24, 2024
Member
Al2Klimov
left a comment
Al2Klimov
left a comment
There was a problem hiding this comment.
Rebased it for you, but there's a lot of trailing whitespace.
Al2Klimov
approved these changes
May 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check_ssl_cert has a new option with a new default: --maximum-validity. This change allows for services to use that option to override the default of 397 days. It is needed, if you have internal certificates that have a longer duration.