Skip to content

Windows: upgrade to VS 2022#9747

Merged
julianbrost merged 1 commit intomasterfrom
vs2022
Jun 17, 2025
Merged

Windows: upgrade to VS 2022#9747
julianbrost merged 1 commit intomasterfrom
vs2022

Conversation

@Al2Klimov
Copy link
Copy Markdown
Member

@Al2Klimov Al2Klimov commented Apr 18, 2023 •
edited by julianbrost
Loading

@Al2Klimov Al2Klimov self-assigned this Apr 18, 2023
@cla-bot cla-bot bot added the cla/signed label Apr 18, 2023
@Al2Klimov
Copy link
Copy Markdown
Member Author

Al2Klimov commented Apr 18, 2023

It seems a valid option: https://community.chocolatey.org/packages/visualstudio2022community

@Al2Klimov Al2Klimov force-pushed the vs2022 branch 2 times, most recently from 2597bb2 to 4b9f0cb Compare April 18, 2023 12:40
@Al2Klimov Al2Klimov force-pushed the vs2022 branch 3 times, most recently from ee35e44 to 6007970 Compare June 7, 2023 15:15
@Al2Klimov Al2Klimov removed their assignment Jun 7, 2023
@Al2Klimov Al2Klimov marked this pull request as ready for review June 7, 2023 15:38
@Al2Klimov Al2Klimov self-assigned this Jun 12, 2023
@Al2Klimov Al2Klimov marked this pull request as draft June 12, 2023 11:45
@Al2Klimov
Copy link
Copy Markdown
Member Author

Al2Klimov commented Jun 12, 2023

Can wait until April 2029 (VS '19 EOL). Who knows what happens by then. (https://icinga.com/blog/2023/05/17/the-future-of-icinga-windows-schrodingers-agent/)

@Al2Klimov Al2Klimov removed their assignment Jun 12, 2023
@Al2Klimov
Copy link
Copy Markdown
Member Author

Al2Klimov commented Jun 12, 2023

💡 Not to mention possible future new VS versions by then.

@Al2Klimov Al2Klimov mentioned this pull request Oct 23, 2024
Closed
@Al2Klimov Al2Klimov closed this Nov 6, 2024
@icinga-probot icinga-probot bot deleted the vs2022 branch November 6, 2024 17:04
@Al2Klimov Al2Klimov restored the vs2022 branch June 11, 2025 08:09
@Al2Klimov Al2Klimov reopened this Jun 11, 2025
@julianbrost julianbrost mentioned this pull request Jun 11, 2025
Closed
@Al2Klimov Al2Klimov self-assigned this Jun 11, 2025
@Al2Klimov Al2Klimov marked this pull request as ready for review June 12, 2025 10:06
@Al2Klimov Al2Klimov marked this pull request as draft June 12, 2025 11:33
@Al2Klimov Al2Klimov removed their assignment Jun 12, 2025
@Al2Klimov Al2Klimov marked this pull request as ready for review June 12, 2025 15:57
@Al2Klimov Al2Klimov requested a review from julianbrost June 12, 2025 15:57
@Al2Klimov Al2Klimov added this to the 2.15.0 milestone Jun 12, 2025
@julianbrost
Copy link
Copy Markdown
Member

julianbrost commented Jun 13, 2025

If you have tested compatibility down to at least Windows Server 2016 (with #10473 addressed of course), the change is fine for me.

@Al2Klimov
Copy link
Copy Markdown
Member Author

Al2Klimov commented Jun 13, 2025

  1. "down to" = all versions in question?
  2. "with # 10473 addressed" Then let's wait for Latest snapshot broken on Server 2019 x64 #10473 and re-test.

@julianbrost
Copy link
Copy Markdown
Member

julianbrost commented Jun 13, 2025

  1. "down to" = all versions in question?

It has to work on all versions listed on https://icinga.com/subscriptions/support-matrix/. Though I'd be happy with testing only 2016 for the moment (given that Windows is typically very backwards compatible for stuff that worked on older versions).

  1. "with # 10473 addressed" Then let's wait for Latest snapshot broken on Server 2019 x64 #10473 and re-test.

Who will unblock that waiting, i.e. will you create a PR to fix it?

@Al2Klimov Al2Klimov mentioned this pull request Jun 13, 2025
Open
Al2Klimov
Al2Klimov commented Jun 16, 2025
View reviewed changes
Copy link
Copy Markdown
Member Author

@Al2Klimov Al2Klimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Server 2012 R2
  • Server 2016
  • Server 2019

Icinga made it to "information/ConfigItem: Activated all objects." 👍

@Al2Klimov Al2Klimov marked this pull request as draft June 16, 2025 11:04
@Al2Klimov Al2Klimov marked this pull request as ready for review June 16, 2025 11:33
@julianbrost julianbrost changed the base branch from master to windows-installer-compat June 16, 2025 11:39
@julianbrost
Copy link
Copy Markdown
Member

julianbrost commented Jun 16, 2025

Rebase Attempt to edit the title in order to change the base branch master -> master to get rid of 15a8114

Fixed that for you: if you change the base branch to the other PR, it already shows correctly and once that's merged, the base branch will be updated.

Base automatically changed from windows-installer-compat to master June 16, 2025 12:22
julianbrost
julianbrost reviewed Jun 16, 2025
View reviewed changes
doc/win-dev.ps1
git `
cmake `
winflexbison3 `
netfx-4.6-devpack `
Copy link
Copy Markdown
Member

@julianbrost julianbrost Jun 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a replacement for visualstudio${VsVersion}-workload-netcoretools? This is the only non-obvious change here, so a few more words on it would be nice.

Copy link
Copy Markdown
Member Author

@Al2Klimov Al2Klimov Jun 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise Icinga 2 build fails:

C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\MSBuild\Current\Bin\amd64\Microsoft.Common.CurrentVersion.targets(1259,5): error MSB3644: The reference assemblies for .NETFramework,Version=v4.6 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks [C:\Untrusted-Build\builds\qmJF7LoKb\1\aklimov\windows-icinga2\icinga2\agent\windows-setup-agent\Icinga2SetupAgent.csproj]

@julianbrost julianbrost merged commit 3c9b469 into master Jun 17, 2025
25 checks passed
@julianbrost julianbrost deleted the vs2022 branch June 17, 2025 08:07
@julianbrost julianbrost added area/windows Windows agent and plugins area/ci CI/CD consider backporting Should be considered for inclusion in a bugfix release labels Jun 17, 2025
@julianbrost julianbrost changed the title GHA: Windows: upgrade to VS 2022 Windows: upgrade to VS 2022 Jun 17, 2025
@julianbrost julianbrost mentioned this pull request Jun 17, 2025
Merged
5 tasks
@yhabteab yhabteab mentioned this pull request Oct 9, 2025
Merged
@yhabteab yhabteab added backported Fix was included in a bugfix release and removed consider backporting Should be considered for inclusion in a bugfix release labels Oct 9, 2025
@yhabteab yhabteab mentioned this pull request Oct 9, 2025
Merged
@Al2Klimov Al2Klimov mentioned this pull request Jan 22, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@julianbrost julianbrost julianbrost approved these changes

Assignees

No one assigned

Labels

area/ci CI/CD area/windows Windows agent and plugins backported Fix was included in a bugfix release cla/signed

Projects

None yet

Milestone

2.15.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Al2Klimov @julianbrost @yhabteab