Skip to content

GHA: Unbreak Windows Tests#10453

Merged
Al2Klimov merged 1 commit intosupport/2.12from
gha-windows-ctest-fix-212
May 22, 2025
Merged

GHA: Unbreak Windows Tests#10453
Al2Klimov merged 1 commit intosupport/2.12from
gha-windows-ctest-fix-212

Conversation

@yhabteab
Copy link
Copy Markdown
Member

Backport of #10104


As seen in the recent GHA run for #10102, the two Windows Actions have failed. The output log contains:

DEBUG: 27+ >>>> ctest.exe -C "${env:CMAKE_BUILD_TYPE}" -T test -O $env:ICINGA2_BUILDPATH/Test.xml
--output-on-failure --log_level=all
CMake Error: Unknown argument: --log_level=all
CMake Error: Run 'ctest --help' for all supported options.

After consulting ctest(1), older versions included, I have never found a mention of the "--log_level" flag. Since the useful "--output-on-failure" flag is already set, which will "[o]utput anything outputted by the test program if the test should fail", I do not see any further reason for more logging information.

This flag was introduced in 7665143, but I have not found any reasoning for the flag in particular.

As seen in the recent GHA run for #10102, the two Windows Actions have
failed. The output log contains:

> DEBUG:   27+  >>>> ctest.exe -C "${env:CMAKE_BUILD_TYPE}" -T test -O $env:ICINGA2_BUILDPATH/Test.xml
> --output-on-failure --log_level=all
> CMake Error: Unknown argument: --log_level=all
> CMake Error: Run 'ctest --help' for all supported options.

After consulting ctest(1), older versions included, I have never found a
mention of the "--log_level" flag. Since the useful
"--output-on-failure" flag is already set, which will "[o]utput anything
outputted by the test program if the test should fail", I do not see any
further reason for more logging information.

This flag was introduced in 7665143,
but I have not found any reasoning for the flag in particular.
@cla-bot cla-bot bot added the cla/signed label May 22, 2025
@Al2Klimov Al2Klimov merged commit d6f119c into support/2.12 May 22, 2025
13 of 19 checks passed
@Al2Klimov Al2Klimov deleted the gha-windows-ctest-fix-212 branch May 22, 2025 09:48
@Al2Klimov Al2Klimov added this to the 2.12.12 milestone May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants