ITL: add argument maintenance_mode_state to vmware_esx#10435
ITL: add argument maintenance_mode_state to vmware_esx#10435julianbrost merged 2 commits intoIcinga:masterfrom
Conversation
|
Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA). Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA. After that, please reply here with a comment and we'll verify. Contributors that have not signed yet: @SpeedD3 Details
|
|
@cla-bot check |
oxzi
left a comment
oxzi
left a comment
There was a problem hiding this comment.
Thanks for this PR. Please address the comments I made.
oxzi
force-pushed
the
itl/vmware.esx/maintenance_mode_state
branch
from
220380c to
0c06ea4
Compare
There was a problem hiding this comment.
Please have another look at this file. The tables are now aligned using a mix of spaces and tabs, so there are out of alignment when viewed with anything except tab width 8.
There was a problem hiding this comment.
Damn.. The preview GitHub rendered for me didn't highlighted this. I am going to change this. Thanks.
There was a problem hiding this comment.
After unleashing a vim macro (and some manual cleanup afterwards), all related tables should now be formatted only by spaces. Would you mind to take another look?
oxzi
force-pushed
the
itl/vmware.esx/maintenance_mode_state
branch
from
0c06ea4 to
908519a
Compare
5 participants
Fixes #10434.
ref/NC/855623