Improvements to core dumps section in developer documentation (and some smaller stuff)#10418
Conversation
jschmidt-icinga
force-pushed
the
jschmidt/doc-impr-unity-builds-core-dumps
branch
2 times, most recently
from
dbc84a9 to
f02d06b
Compare
|
Fyi: I've pushed a full rebase with the added changes so the base of the branch gets past the commit on master adding me to the |
julianbrost
left a comment
julianbrost
left a comment
There was a problem hiding this comment.
You're adding some quite long lines there, so can you please wrap them? There isn't really a strict limit for this file and also it's not perfectly consistent at the moment. For me it's "I won't complain if it adheres to a reasonable limit with reasonable being at most 120 characters".
Personally I'd prefer letting the editor handle line breaks in regular text (i.e. not code or code comments), but to maintain consistency I'll break it down to a column-width of 100-120 characters. |
Corrected one instance where `CMake` was spelled as `cmake` despite the rest of the docs using the first spelling.
Atom is already dead. But Emacs will outlast human civilization.
You can only 'recognize' something you already know and 'another thing', while not necessarily wrong does not seem right here when there isn't a 'first thing' to notice.
We didn't really 'invent' unity builds, more like adopted them, since this is a common practice. Also added a reference to the actual CMake variable in question instead of just alluding to it
jschmidt-icinga
force-pushed
the
jschmidt/doc-impr-unity-builds-core-dumps
branch
from
f02d06b to
18eb679
Compare
|
@julianbrost I've pushed a new version with the lines broken to ~80 columns and SIGABRT mentioned. |
jschmidt-icinga
force-pushed
the
jschmidt/doc-impr-unity-builds-core-dumps
branch
from
18eb679 to
c1bca3e
Compare
|
@julianbrost I've pushed a new version with the requested changes. |
|
@oxzi I heard you like documentation, do you want to also have a look? 😅 |
oxzi
left a comment
oxzi
left a comment
There was a problem hiding this comment.
Very well written, thanks a lot! I have only added one note, please feel free to either address it or decline it, as you like.
jschmidt-icinga
force-pushed
the
jschmidt/doc-impr-unity-builds-core-dumps
branch
from
c1bca3e to
9350e3a
Compare
jschmidt-icinga
force-pushed
the
jschmidt/doc-impr-unity-builds-core-dumps
branch
from
9350e3a to
88b2831
Compare
|
PR doesn't touch the code, the failing pipeline would be fixed by #10430 but I see little value in rebasing here just to rebuild the unchanged code, hence I'll force-merge. |
4 participants
Core Dumps
Updated and added more information to set up generating core dumps, touching and expanding on systemd's coredumpctl, Ubuntu's apport and the conventional method.
This fixes #8714.
Unity Builds
Rephrased some sentences to make them more understandably and avoid awkward claims like Icinga 'inventing' unity builds.
Preferred Editors
Removed Atom and added Emacs. 😁
Typos
Also fixed a few typos and capitalization errors (maybe added a few too).
I'm happy to incorporate any further suggestions.