Skip to content

ITL vmware-esx-soap-host-net{,-nic}: Add missing option "--unplugged_nics_state" #10261

Merged
oxzi merged 1 commit intoIcinga:masterfrom
n-rodriguez:wip/unplugged_nics_state
Jan 8, 2025
Merged

ITL vmware-esx-soap-host-net{,-nic}: Add missing option "--unplugged_nics_state" #10261
oxzi merged 1 commit intoIcinga:masterfrom
n-rodriguez:wip/unplugged_nics_state

Conversation

@n-rodriguez
Copy link
Copy Markdown
Contributor

@n-rodriguez n-rodriguez commented Nov 30, 2024

Hi there!

Add missing option --unplugged_nics_state to vmware-esx-soap-host-net and vmware-esx-soap-host-net-nic.

It's a revival of #8618, hope it will be merged 😃

Thank you!

@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Nov 30, 2024

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @n-rodriguez

Details

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

1 similar comment
@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Nov 30, 2024

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @n-rodriguez

Details

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

@n-rodriguez
Copy link
Copy Markdown
Contributor Author

n-rodriguez commented Nov 30, 2024

CLA is signed

@bobapple
Copy link
Copy Markdown
Member

bobapple commented Dec 2, 2024

@cla-bot check

@cla-bot cla-bot bot added the cla/signed label Dec 2, 2024
@oxzi oxzi changed the title Add missing option "--unplugged_nics_state" ITL vmware-esx-soap-host-net{,-nic}: Add missing option "--unplugged_nics_state" Dec 2, 2024
@oxzi oxzi added the area/itl Template Library CheckCommands label Dec 2, 2024
oxzi
oxzi reviewed Dec 2, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@oxzi oxzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution!

Please address the one change I have commented. Otherwise, it looks good to me.

@n-rodriguez
Copy link
Copy Markdown
Contributor Author

n-rodriguez commented Dec 2, 2024

Please address the one change I have commented. Otherwise, it looks good to me.

@oxzi done!

oxzi
oxzi approved these changes Dec 3, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@oxzi oxzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for your contribution. Looks good to me!

oxzi
oxzi reviewed Dec 3, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@oxzi oxzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, since you are a new contributor, there is one more thing you need to do. Please add yourself to the AUTHORS file at the correct alphabetical position. Please apologize that I forgot to mention this before.

oxzi

This comment was marked as off-topic.

Sign in to view

oxzi
oxzi requested changes Dec 3, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@oxzi oxzi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please excuse the mess with the multiple comments.. I just wanted to change the status to requested changes, but GitHub had other plans for me. Thus, please address my previous comment: #10261 (review)

@n-rodriguez
Copy link
Copy Markdown
Contributor Author

n-rodriguez commented Dec 3, 2024

@oxzi done!

oxzi
oxzi approved these changes Dec 4, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@oxzi oxzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks again.

@n-rodriguez
Copy link
Copy Markdown
Contributor Author

n-rodriguez commented Dec 19, 2024

Hi there! Any news?

@Al2Klimov Al2Klimov self-requested a review January 2, 2025 10:18
@Al2Klimov Al2Klimov removed their assignment Jan 2, 2025
@oxzi oxzi added the enhancement New feature or request label Jan 8, 2025
@oxzi oxzi merged commit c596371 into Icinga:master Jan 8, 2025
@oxzi
Copy link
Copy Markdown
Member

oxzi commented Jan 8, 2025

Thanks for your contribution :)

@yhabteab yhabteab added this to the 2.15.0 milestone Jan 8, 2025
@n-rodriguez n-rodriguez deleted the wip/unplugged_nics_state branch January 9, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oxzi oxzi oxzi approved these changes

@Al2Klimov Al2Klimov Awaiting requested review from Al2Klimov

Assignees

No one assigned

Labels

area/itl Template Library CheckCommands cla/signed enhancement New feature or request

Projects

None yet

Milestone

2.15.0

Development

Successfully merging this pull request may close these issues.

5 participants

@n-rodriguez @bobapple @oxzi @Al2Klimov @yhabteab