Merge pull request #10359 from Icinga/do-not-publish-useless-stats

yhabteab · web-flow · commit 206d7cda1bac · 2025-03-07T12:51:10.000+01:00
IcingaDB: Don't publish useless data to Redis
diff --git a/lib/icingadb/icingadb-stats.cpp b/lib/icingadb/icingadb-stats.cpp
@@ -12,42 +12,15 @@ using namespace icinga;
 
 Dictionary::Ptr IcingaDB::GetStats()
 {
-	Dictionary::Ptr stats = new Dictionary();
-
-	//TODO: Figure out if more stats can be useful here.
-	Namespace::Ptr statsFunctions = ScriptGlobal::Get("StatsFunctions", &Empty);
-
-	if (!statsFunctions)
-		Dictionary::Ptr();
-
-	ObjectLock olock(statsFunctions);
-
-	for (auto& kv : statsFunctions)
-	{
-		Function::Ptr func = kv.second.Val;
-
-		if (!func)
-			BOOST_THROW_EXCEPTION(std::invalid_argument("Invalid status function name."));
-
-		Dictionary::Ptr status = new Dictionary();
-		Array::Ptr perfdata = new Array();
-		func->Invoke({ status, perfdata });
-
-		stats->Set(kv.first, new Dictionary({
-			{ "status", status },
-			{ "perfdata", Serialize(perfdata, FAState) }
-		}));
-	}
-
-	typedef Dictionary::Ptr DP;
-	DP app = DP(DP(DP(stats->Get("IcingaApplication"))->Get("status"))->Get("icingaapplication"))->Get("app");
+	Dictionary::Ptr status = new Dictionary();
+	IcingaApplication::StatsFunc(status, nullptr);
 
+	Dictionary::Ptr app(Dictionary::Ptr(status->Get("icingaapplication"))->Get("app"));
 	app->Set("program_start", TimestampToMilliseconds(Application::GetStartTime()));
 
-	auto localEndpoint (Endpoint::GetLocalEndpoint());
-	if (localEndpoint) {
+	if (auto localEndpoint(Endpoint::GetLocalEndpoint()); localEndpoint) {
 		app->Set("endpoint_id", GetObjectIdentifier(localEndpoint));
 	}
 
-	return stats;
+	return new Dictionary{{ "IcingaApplication", new Dictionary{{"status", status}}}};
 }
diff --git a/lib/icingadb/icingadb.hpp b/lib/icingadb/icingadb.hpp
@@ -143,7 +143,7 @@ class IcingaDB : public ObjectImpl<IcingaDB>
 	Dictionary::Ptr SerializeState(const Checkable::Ptr& checkable);
 
 	/* Stats */
-	Dictionary::Ptr GetStats();
+	static Dictionary::Ptr GetStats();
 
 	/* utilities */
 	static String FormatCheckSumBinary(const String& str);
