ceptr:Improved T polynomial in mechanism.H#13
Merged
terencelehmann merged 2 commits intopush_branchfrom Apr 4, 2025
Merged
Conversation
|
Close #12 |
terencelehmann
requested changes
Jan 22, 2025
terencelehmann
left a comment
terencelehmann
left a comment
There was a problem hiding this comment.
Please update the description of the merge request.
terencelehmann
approved these changes
Apr 4, 2025
terencelehmann
changed the title
ThomasHowarth
added a commit
that referenced
this pull request
Jul 28, 2025
…MReX-Combustion#595) * changed size of dbin * adjusted the way COFD is saved in transport, and used in simple * fixed my weird iterating and made it map vertically, not horizontaly * changed the iteratios through dbin and calculations of Ddiag * tweaked the calculations for the diffusivities * adjusting the SRK diffusion * adjusted the array size in TransportParams * fixed an error with the implementation of the mole fraction within my equation * added mechanism.* to branch * ceptr:Improved T polynomial in mechanism.H(#13) Instead of evaluation T2= T*T and T3=T*T*T do T3=T2*T Co-authored-by: Terence Lehmann <[email protected]> * ran some clang formatting on Simple.H * ran clang format over transport.py * more formatting * remade almost all of the mechanisms * cleaned up the code for the push * Fix comments * Fix comments 2 * changed size of dbin * adjusted the way COFD is saved in transport, and used in simple * fixed my weird iterating and made it map vertically, not horizontaly * changed the iteratios through dbin and calculations of Ddiag * tweaked the calculations for the diffusivities * adjusting the SRK diffusion * adjusted the array size in TransportParams * fixed an error with the implementation of the mole fraction within my equation * added mechanism.* to branch * ran some clang formatting on Simple.H * ran clang format over transport.py * more formatting * remade almost all of the mechanisms * cleaned up the code for the push * Adding the temperature change to the mechanism * fixxed the logT Error * Redo formating of comment * Variable optimisation * adjusted the SRK part of the equation as well * formatting * typo * qss mechanism * qss mech updates without extraneous changes * fix sympy version more strictly in ceptr --------- Co-authored-by: Justin Freiberger <[email protected]> Co-authored-by: Terence Lehmann <[email protected]> Co-authored-by: terence.lehmann <[email protected]> Co-authored-by: Thomas Howarth <[email protected]> Co-authored-by: Thomas Howarth <[email protected]> Co-authored-by: Bruce Perry <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjusted the way the equations, regarding the Temperature calculations T2, T3 and T4, were formulated in thermo.py