Skip to content

9829 Use macos-latest runner for shellspec #9830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bencomp wants to merge 1 commit into from
Closed

9829 Use macos-latest runner for shellspec #9830

bencomp wants to merge 1 commit into from

Conversation

@bencomp
Copy link
Contributor

@bencomp bencomp commented Aug 25, 2023

What this PR does / why we need it:
It updates the Shellspec workflow to use the newer MacOS runners, since the macos-10.15 are no longer available causing all Shellspec workflow to fail after being queued for a day.

Which issue(s) this PR closes:

Closes #9829

Special notes for your reviewer:
I assume that shellspec works the same on MacOS 11 and up as on MacOS 10.15. I have not tested this.

Suggestions on how to test this:
See that the new jobs pass.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No.

Is there a release notes update needed for this change?:
Maybe; if release notes (should) include MacOS compatibility notes, then yes.

Additional documentation:

@pdurbin
Copy link
Member

pdurbin commented Aug 25, 2023

@bencomp do you want to try making a no-op edit to a shell script to trigger the shellspec workflow?

From what I see below even something under tests/shell would trigger it? @poikilotherm set this up and would know for sure.

name: "Shellspec"
on:
    push:
        paths:
            - tests/shell/**
            - conf/solr/**
            # add more when more specs are written relying on data
    pull_request:
        paths:
            - tests/shell/**
            - conf/solr/**
            # add more when more specs are written relying on data

@pdurbin pdurbin requested a review from poikilotherm August 25, 2023 14:52
@bencomp
Copy link
Contributor Author

bencomp commented Aug 25, 2023

@pdurbin I could try, but I think only workflows that are on the default branch are run – to prevent cryptominer PRs and other bad stuff. So before this is merged even a no-op change should trigger a job for macos-10.15.

@bencomp
Copy link
Contributor Author

bencomp commented Aug 25, 2023

Okay, I did manage to test: https://github.com/bencomp/dataverse/actions/runs/5977459978/job/16217490079

🚀

@pdurbin
Copy link
Member

pdurbin commented Aug 25, 2023

Ha. Thanks. 😄

On my PR at https://github.com/IQSS/dataverse/actions/runs/5968226464/job/16191594100?pr=9787 I saw the same thing you are:

Started 19h 22m ago... 
Requested labels: macos-10.15
Job defined at: IQSS/dataverse/.github/workflows/shellspec.yml@refs/pull/9787/merge
Waiting for a runner to pick up this job...

I cherry-picked your commit into my branch: 3944cf1

It seems to have fixed it! Here's the MacOS run: https://github.com/IQSS/dataverse/actions/runs/5977475730/job/16217537483?pr=9787

Some details:

Current runner version: '2.308.0'
Operating System
  macOS
  12.6.7
  21G651
Runner Image
  Image: macos-12
  Version: 20230812.3
  Included Software: https://github.com/actions/runner-images/blob/macOS-12/20230812.3/images/macos/macos-12-Readme.md
  Image Release: https://github.com/actions/runner-images/releases/tag/macOS-12%2F20230812.3

I marked my PR as closing the issue you opened:

I believe this PR will auto-close when my PR is merged. (Or you can go ahead and close it if you want.)

Thanks! Welcome back! 🎉 ❤️ 🚀

@bencomp
Copy link
Contributor Author

bencomp commented Aug 25, 2023

Eh, I will wait and see which is merged first ;)

Perhaps you want to cancel the queued jobs that are waiting for the old runners?

@pdurbin pdurbin mentioned this pull request Aug 25, 2023
Merged
@bencomp bencomp closed this Aug 28, 2023
@bencomp
Copy link
Contributor Author

bencomp commented Aug 28, 2023

Issue was solved in #9787

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@poikilotherm poikilotherm Awaiting requested review from poikilotherm

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Shellspec jobs and workflows fail because no MacOS (10.15) runner is available

2 participants

@bencomp @pdurbin