#9739 - URLValidator now allows two slashes in the path component of the URL #9750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qqmyers
approved these changes
Aug 2, 2023
Member
qqmyers
left a comment
qqmyers
left a comment
There was a problem hiding this comment.
Looks good. FYI - I did a quick check and UrlValidator is also used to decide whether the forwarding URL for a deaccessioned dataset is OK. I think allowing two slashes there is also OK, but we should be aware that this PR as is will change that as well.
Member
|
The ec2 instance didn't spin up. I just triggered another run of the API tests: https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-9750/2/ |
Contributor
|
@luddaniel a small release note for this change would ne nice for users, as well. |
Contributor
Author
|
@scolapasta release node is added |
scolapasta
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
URLValidator now allows two slashes in the path component of the URL
Which issue(s) this PR closes:
Closes #9739
Special notes for your reviewer:
From what I see, URLValidator is used to :
As discussed in #9739, a user is able to provide "valid" syntax url that can be "invalid" when used, so allowing two slashes in the path component of the URL seems to not bring any danger.
Suggestions on how to test this:
Example of allowed url : https://archive.softwareheritage.org/swh:1:dir:561bfe6698ca9e58b552b4eb4e56132cac41c6f9;origin=https://github.com/gem-pasteur/macsyfinder;visit=swh:1:snp:1bde3cb370766b10132c4e004c7cb377979928d1;anchor=swh:1:rev:868637fce184865d8e0436338af66a2648e8f6e1
Does this PR introduce a user interface change?
No
Is there a release notes update needed for this change?
No