QDR/9172-fix messages #9173
Merged
QDR/9172-fix messages #9173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haarli
added a commit
to MPDL/dataverse
that referenced
this pull request
Nov 23, 2022
|
Raised by Gary. |
|
added to sprint Dec 15, 2022 |
scolapasta
approved these changes
Dec 15, 2022
haarli
added a commit
to MPDL/dataverse
that referenced
this pull request
Mar 30, 2023
cmbz
added
FY26 Sprint 14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: #9056 added the dataset displayname to some messages but a bug/partial fix introduced in review led to some messages display an empty
"". This PR fixes that.Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this: Do what's needed to generate messages of any/all types below and verify that the message includes the dataset displayname. If one works, they all should.
Regression testing: The message to users when a dataset is created should also show the dataset display name. No other messages (such as REQUESTFILEACCESS) should be broken.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: no? relatively minor message display bug
Additional documentation: