Proper detection of IP addresses in JSF context #3103

michbarsinai · 2016-05-04T19:59:48Z

RFI Checklist

Before submitting the pull request, fill out sections (1.) Related Issues and (2.) Pull Request Checklist.

1. Related Issues

IP Groups: Define and enforce IP Group scope of permissions in application #1380 IP Groups: Define and enforce IP Group scope of permissions in application
Unpublished DvObjects' cards don't show for IpGroups contained within a group that has permission to view them. #3273 Unpublished DvObjects' cards don't show for IpGroups contained within a group that has permission to view them.
My Data: Does not display access via IP Groups permissions #3275 My Data: Does not display access via IP Groups permissions
IPGroups: Attempting to create a group with a duplicate name throws an error. #3376 Attempting to create an IP Group with a duplicate name causes an error rather than updates it.

2. Pull Request Checklist

Functionality completed as described in FRD
Dependencies, risks, assumptions in FRD addressed
Unit tests completed (None available, fixing the issue required accessing the JSF context)
Deployment requirements identified (e.g., SQL scripts, indexing)
Documentation completed
All code checkins completed

3. Review Checklist

After the pull request has been submitted, fill out this section.

Code review completed or waived
Testing requirements completed
Usability testing completed or waived
Support testing completed or waived
Merged with develop branch and resolved conflicts

Connects to #3376.

coveralls · 2016-05-04T20:39:04Z

Coverage decreased (-0.0006%) to 5.013% when pulling 90b3a02 on 1380-honor-ip-groups into bb0a5d8 on develop.

kcondon · 2016-05-06T20:24:44Z

Michael, datasets and files are still not working and cannot assign ip groups to explicit groups. I've updated the original ticket.

pdurbin · 2016-05-31T14:26:13Z

@michbarsinai heads up that this pull request now has conflicts that must be resolved before it can be merged.

coveralls · 2016-07-14T16:12:58Z

Coverage decreased (-0.0007%) to 5.133% when pulling 014eb7c on 1380-honor-ip-groups into dcea42d on develop.

kcondon · 2016-07-18T18:42:36Z

@michbarsinai , I am able to assign a member role to ipGroup3, all addresses, but cannot navigate directly to an unpublished dv. It does appear in the UI and API as a role assignment. Passing back for comment.

djbrooke · 2016-08-02T18:19:44Z

This came up in the 8/2 Community Call (https://docs.google.com/document/d/1FsXatbbq-F4qwD_w9dqkFXpr2Sd4MqScKevUcHLCVDY/edit).

coveralls · 2016-08-03T14:05:26Z

Coverage decreased (-0.003%) to 6.779% when pulling 4fff55d on 1380-honor-ip-groups into 054cafb on develop.

…oup-localhost.json)

coveralls · 2016-08-04T12:57:32Z

Coverage increased (+0.3%) to 7.063% when pulling a336475 on 1380-honor-ip-groups into 054cafb on develop.

… roles

coveralls · 2016-08-04T13:42:06Z

Coverage increased (+0.3%) to 7.062% when pulling 2ee3fad on 1380-honor-ip-groups into 054cafb on develop.

coveralls · 2016-08-04T15:07:32Z

Coverage increased (+0.3%) to 7.065% when pulling affb6b3 on 1380-honor-ip-groups into 054cafb on develop.

… a range (solves #3340)

Merging the fix for #3340 (b0c0779)

Fix DataONE Maven URL. Conflicts: pom.xml

coveralls · 2016-09-12T19:37:22Z

Coverage increased (+0.7%) to 8.595% when pulling 00decd4 on 1380-honor-ip-groups into 5a10180 on develop.

pdurbin · 2016-09-12T19:42:36Z

I just merged the latest from "develop" into this pull request: 00decd4

In a refactoring at c10cbd9 we lost the meaning of 0.0.0.0 which was "Setting address to undefined (0.0.0.0)" so this commit makes the code clearer. A note has been added that Saved Search may not play nicely with IP Groups but this should probably be addressed along with the long list of other Saved Search issues mentioned in the API Guide: #1364, #1813, #1840, #1890, #1939, #2167, #2186, #2053 and #2543

coveralls · 2016-09-15T13:11:54Z

Coverage increased (+0.7%) to 8.595% when pulling d110ce2 on 1380-honor-ip-groups into 5a10180 on develop.

coveralls · 2016-09-20T02:01:14Z

Coverage increased (+0.7%) to 8.595% when pulling 128915b on 1380-honor-ip-groups into 5a10180 on develop.

…ash where IP groups were updated (ref #1380, #3376)

…mantics more idiomatic now (POST generates something under a URI, PUT puts it in an exact place). Re: #1380 #3376

Conflicts: src/main/java/edu/harvard/iq/dataverse/api/BuiltinUsers.java src/main/java/edu/harvard/iq/dataverse/authorization/groups/impl/ipaddre ss/IpGroup.java src/main/java/edu/harvard/iq/dataverse/authorization/users/Authenticated User.java

coveralls · 2016-09-23T18:46:36Z

Coverage increased (+0.7%) to 8.582% when pulling 30c50fb on 1380-honor-ip-groups into e054b8c on develop.

Proper detection of IP addresses in JSF context

90b3a02

michbarsinai assigned kcondon May 4, 2016

kcondon assigned michbarsinai and unassigned kcondon May 6, 2016

Merged with updated develop

014eb7c

scolapasta assigned kcondon Jul 14, 2016

scolapasta added the Status: QA label Jul 14, 2016

scolapasta unassigned michbarsinai Jul 14, 2016

kcondon removed their assignment Jul 18, 2016

kcondon added Status: Dev and removed Status: QA labels Jul 18, 2016

kcondon assigned michbarsinai Jul 18, 2016

djbrooke added in progress and removed Status: Dev labels Jul 29, 2016

Resynced current code with origin/develop

4fff55d

This was referenced Aug 3, 2016

IP Groups: Cards for dataverse, dataset, files do not appear after access granted to group. #3105

Closed

Index: Cannot see unpublished dv or ds if assigned proper view perms as IPGroup. #1513

Closed

IP group json format now supports single addresses (see usage in ipGr…

a336475

…oup-localhost.json)

Fix error message for attempts to delete IP groups that have assinged…

2ee3fad

… roles

(Part of #1380) IP groups are now honored by the dataset page

affb6b3

raprasad and others added 7 commits September 9, 2016 15:16

updates for changing authUser to dataverseRequest #3275

095d918

updates re: dataverseRequest

2a898e6

remove redundant code

bd3630a

compiling...

64952cc

working on #3275; need to add queries for ip groups

09050e3

IP ranges containing single IP appear as a single address rather than…

b0c0779

… a range (solves #3340)

Merge branch '1380-honor-ip-groups' into mydata-ipgroups

5ec0cdf

Merging the fix for #3340 (b0c0779)

pdurbin mentioned this pull request Sep 12, 2016

My Data: Does not display access via IP Groups permissions #3275

Closed

sekmiller and others added 3 commits September 12, 2016 15:18

#3275 Add CollectAncestors for MyData groups

d50351d

turn down logging #3275

9eba927

Merge branch 'develop' into mydata-ipgroups

00decd4

Fix DataONE Maven URL. Conflicts: pom.xml

pdurbin unassigned pdurbin and michbarsinai Sep 12, 2016

Added more tests and sample data for ipGroups

128915b

michbarsinai added 5 commits September 23, 2016 06:17

Fixed a crash when searching a nonexistent IP Group. Fixed another cr…

f87c142

…ash where IP groups were updated (ref #1380, #3376)

Added REST methods for creation and editing of IP Groups. REST API se…

9444ee1

…mantics more idiomatic now (POST generates something under a URI, PUT puts it in an exact place). Re: #1380 #3376

Merge branch 'develop' into 1380-honor-ip-groups

17fc39b

Fixed merge conflicts

30c50fb

kcondon merged commit ecde099 into develop Sep 23, 2016

pdurbin mentioned this pull request Oct 3, 2016

IP Groups: Continue to support IP Groups for v4.0 and add better support for specifying ranges such as subnets. #700

Closed

mheppler removed Status: Dev labels Oct 11, 2016

pdurbin deleted the 1380-honor-ip-groups branch October 14, 2016 19:58

Proper detection of IP addresses in JSF context #3103

Proper detection of IP addresses in JSF context #3103

Uh oh!

Conversation

michbarsinai commented May 4, 2016 • edited by kcondon Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

RFI Checklist

1. Related Issues

2. Pull Request Checklist

3. Review Checklist

Uh oh!

coveralls commented May 4, 2016

Uh oh!

kcondon commented May 6, 2016

Uh oh!

pdurbin commented May 31, 2016

Uh oh!

coveralls commented Jul 14, 2016

Uh oh!

kcondon commented Jul 18, 2016

Uh oh!

djbrooke commented Aug 2, 2016

Uh oh!

coveralls commented Aug 3, 2016

Uh oh!

coveralls commented Aug 4, 2016

Uh oh!

coveralls commented Aug 4, 2016

Uh oh!

coveralls commented Aug 4, 2016

Uh oh!

coveralls commented Sep 12, 2016

Uh oh!

pdurbin commented Sep 12, 2016

Uh oh!

coveralls commented Sep 15, 2016

Uh oh!

coveralls commented Sep 20, 2016

Uh oh!

coveralls commented Sep 23, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

michbarsinai commented May 4, 2016 •

edited by kcondon

Loading