Adapt to LC's change to use doi array #11904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofahimIQSS
moved this from Ready for Triage
to Ready for Review ⏩
in IQSS Dataverse Project
stevenwinship
moved this from Ready for Review ⏩
to In Review 🔎
in IQSS Dataverse Project
stevenwinship
approved these changes
Nov 4, 2025
github-project-automation
bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
cmbz
added
FY26 Sprint 9
Member
Author
|
FYI w.r.t. QA - the build is currently failing due to maven.dataone.org being unresponsive. The prior build passed (https://jenkins.dataverse.org/blue/organizations/jenkins/IQSS-Dataverse-Develop-PR/detail/PR-11904/5/pipeline/) and the only change since was just to fix a conflict in the list of IT tests being run. |
github-project-automation
bot
moved this from QA ✅
to Merged 🚀
in IQSS Dataverse Project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: LocalContexts has updated their software and is replacing the publication_doi field with a doi array of values. (They do have some backward compatibility for using publication_doi, but this field is not populated for new projects on their site.) This PR updates Dataverse's queries to address that change, looking in the doi array for the dataset's PID and searching the doi array. It also makes a change to just search for the raw PID which, since LC does a 'contains' search internally, will match regardless of whether the user enters the doi:* form, or the https://doi.org/* form. A similar change checks for one of the two forms when retrieving specific project info.
To Do:
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this: On a machine configured for LocalContexts, assure that one can link/unlink an LC project using the LocalContexts metadata block.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: