Skip to content

Conversation

@stevenwinship
Copy link
Contributor

@stevenwinship stevenwinship commented Sep 5, 2025

What this PR does / why we need it: When you have a published dataset with restricted files, and you create a draft of the dataset with additional new restricted files, and you are assigning file level permission to the published version, the files in the draft dataset are showing up on the list of restricted files in the permissions page. There is no indication to the admin that the "draft dataset files" have yet to be published. This can cause admins to accidentally give access to files not intended for use. Draft file should not even show up here. (It was decided to have it show up there but add a tag stating this file is an unpublished draft)

Which issue(s) this PR closes:#7618

Special notes for your reviewer:

Suggestions on how to test this: Follow the steps in the main issue

Does this PR introduce a user interface change? If mockups are available, please link/include them here:
image

Is there a release notes update needed for this change?: Included

Additional documentation:

@github-actions github-actions bot added Feature: Permissions Feature: Publishing & Versions FY26 Sprint 4 FY26 Sprint 4 (2025-08-13 - 2025-08-27) FY26 Sprint 5 FY26 Sprint 5 (2025-08-27 - 2025-09-10) Size: 3 A percentage of a sprint. 2.1 hours. Type: Bug a defect User Role: Depositor Creates datasets, uploads data, etc. labels Sep 5, 2025
@stevenwinship stevenwinship moved this to In Progress 💻 in IQSS Dataverse Project Sep 5, 2025
@stevenwinship stevenwinship self-assigned this Sep 5, 2025
@coveralls
Copy link

coveralls commented Sep 5, 2025

Coverage Status

coverage: 23.778%. remained the same
when pulling 30d62ff on 7618-file-level-permissions-restricted-draft
into 53bff4c on develop.

@github-actions

This comment has been minimized.

@stevenwinship stevenwinship removed their assignment Sep 8, 2025
@stevenwinship stevenwinship moved this from In Progress 💻 to Ready for Review ⏩ in IQSS Dataverse Project Sep 8, 2025
@cmbz cmbz added the FY26 Sprint 6 FY26 Sprint 6 (2025-09-10 - 2025-09-24) label Sep 14, 2025
@cmbz cmbz added the FY26 Sprint 7 FY26 Sprint 7 (2025-09-24 - 2025-10-08) label Sep 24, 2025
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@cmbz cmbz added the FY26 Sprint 8 FY26 Sprint 8 (2025-10-08 - 2025-10-22) label Oct 8, 2025
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@stevenwinship stevenwinship removed their assignment Oct 23, 2025
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@stevenwinship stevenwinship removed their assignment Oct 27, 2025
@github-actions
Copy link

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:7618-file-level-permissions-restricted-draft
ghcr.io/gdcc/configbaker:7618-file-level-permissions-restricted-draft

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

Copy link
Member

@qqmyers qqmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@github-project-automation github-project-automation bot moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project Oct 28, 2025
@qqmyers qqmyers removed their assignment Oct 28, 2025
@ofahimIQSS ofahimIQSS self-assigned this Oct 30, 2025
@ofahimIQSS ofahimIQSS moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project Oct 30, 2025
@cmbz cmbz assigned scolapasta and unassigned ofahimIQSS Nov 5, 2025
@cmbz cmbz added the FY26 Sprint 10 FY26 Sprint 10 (2025-11-05 - 2025-11-19) label Nov 5, 2025
@scolapasta scolapasta merged commit 380adfe into develop Nov 20, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this from QA ✅ to Merged 🚀 in IQSS Dataverse Project Nov 20, 2025
@pdurbin pdurbin added this to the 6.9 milestone Nov 21, 2025
@cmbz cmbz added the FY26 Sprint 11 FY26 Sprint 11 (2025-11-20 - 2025-12-03) label Nov 22, 2025
@pdurbin pdurbin moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature: Permissions Feature: Publishing & Versions FY26 Sprint 4 FY26 Sprint 4 (2025-08-13 - 2025-08-27) FY26 Sprint 5 FY26 Sprint 5 (2025-08-27 - 2025-09-10) FY26 Sprint 6 FY26 Sprint 6 (2025-09-10 - 2025-09-24) FY26 Sprint 7 FY26 Sprint 7 (2025-09-24 - 2025-10-08) FY26 Sprint 8 FY26 Sprint 8 (2025-10-08 - 2025-10-22) FY26 Sprint 9 FY26 Sprint 9 (2025-10-22 - 2025-11-05) FY26 Sprint 10 FY26 Sprint 10 (2025-11-05 - 2025-11-19) FY26 Sprint 11 FY26 Sprint 11 (2025-11-20 - 2025-12-03) Size: 3 A percentage of a sprint. 2.1 hours. Type: Bug a defect User Role: Depositor Creates datasets, uploads data, etc.

Projects

Status: Done 🧹

8 participants