-
Notifications
You must be signed in to change notification settings - Fork 531
Templates and Notifications API fixes #11704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Templates and Notifications API fixes #11704
Conversation
This comment has been minimized.
This comment has been minimized.
|
Moving to On Hold, I found other issues with the API that are beyond my limited knowledge of Java.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Assigning @GPortas since I opened the PR, but he continued with the work. |
…-isDefault-property-get-dataset-templates
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Thanks. I fixed the CreateTemplateCommand to persist the default template in the Dataverse entity. I also added a minor fix to the notifications API (not related to the original PR scope). |
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
sekmiller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for the changes/updates. As I mentioned in Stand up, my local test is failing because I have a template in Root, but this should pass with a newly created DB.
|
Hello! I tested this PR with the dataverseadmin account on internal environment. --- This worked curl -H "X-Dataverse-key:$API_TOKEN" "$SERVER_URL/api/notifications/all" --- when running this, i got empty flower brackets {} See log files. The Testing file shows the curl commands I ran along with the second file which is the server logs. |
|
#11683 --- existing Notifications API issue |
What this PR does / why we need it:
Templates API fixes
isDefaultfield to the Get Dataset Templates API response.fileAccessRequestfield of terms of use and access to the Get Dataset Templates API response.contactForAccessfield of terms of use and access to the Get Dataset Templates API response.Notifications API fixes
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
I've extended an existing test.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: