-
Notifications
You must be signed in to change notification settings - Fork 531
Revert #11301 and bump version to 6.7.1 #11700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+7
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
With the wrong line, the "host dataverse" field wasn't working at all!
sekmiller
approved these changes
Jul 30, 2025
Contributor
sekmiller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. (and seems to work - allows you to change the host dv - in the simplest case)
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
Contributor
Member
Author
|
Yes, thanks, fixed. |
pdurbin
added a commit
that referenced
this pull request
Jul 31, 2025
ofahimIQSS
added a commit
that referenced
this pull request
Jul 31, 2025
when cutting a release, base.image.version needs to be "revision" #11700
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: 6.7.1 can be downloaded from https://github.com/IQSS/dataverse/releases/tag/v6.7.1
What this PR does / why we need it:
After deploying 6.7 to Harvard Dataverse, we found a serious performance problem:
The problem is being caused by this PR:
We decided to create a 6.7.1 hotfix release and revert the problematic PR above.
Which issue(s) this PR closes:
Special notes for your reviewer:
We haven't done a hotfix release in a while, since 5.11.1. Things to note:
I think I got it right.However, please review it carefully. Update: I got it slightly wrong at first but between 48bad38 and 7cbd4ba it should be fine now. Thank you to @sekmiller for finding my mistake during code review! ❤️so I'm hoping API tests will pass. Please confirm this. This allowed the API tests to pass: https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-11700/2/testReport/edu.harvard.iq.dataverse.api/ . Pull requests that still have 6.7 as the version will fail until we do the step to merge this the 6.7.1 changes into develop. Stay tuned.Suggestions on how to test this:
On a server with a lot of collections (such as the QA server) try bringing up the "create dataset" and "edit dataset" screens on 6.7. This should be quite slow (for me on Harvard Dataverse it timed out after about 2.5 minutes). Compare with this PR.
Also, on 6.7 the "host dataverse" field will sometimes be absent. "Do not show the host dataverse field when there is nothing to choose." As of this PR the "host dataverse" field will always be present. See the release note snippet in #11301 (there's also language about not erasing your input).
Try browsing to a collection you can create datasets in and click "add dataset". Then change the "host dataverse" to another collection you can create datasets it. Create the dataset. Did it get created in the right collection?
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Yes. See above.
Is there a release notes update needed for this change?:
We'll write the release notes as we draft the release. Our last hotfix was https://github.com/IQSS/dataverse/releases/tag/v5.11.1 and here's a suggested released note based on it.
Dataverse 6.7.1
This is a bug fix release for Dataverse 6.7.1 that fixes a performance problem when loading the "create dataset" and "edit dataset pages". For details see #11700.
Complete List of Changes
For the complete list of code changes in this release, see the 6.7.1 milestone in GitHub.
For help with upgrading, installing, or general questions please post to the Dataverse Community Google Group or email [email protected].
Upgrade Instructions
These instructions assume that you've already upgraded through all the 5.x releases and are now running Dataverse 6.7.
0. These instructions assume that you are upgrading from the immediate previous version. If you are running an earlier version, the only supported way to upgrade is to progress through the upgrades to all the releases in between before attempting the upgrade to this version.
If you are running Payara as a non-root user (and you should be!), remember not to execute the commands below as root. By default, Payara runs as the
dataverseuser. In the commands below, we use sudo to run the commands as a non-root user.Also, we assume that Payara 6 is installed in
/usr/local/payara6. If not, adjust as needed.export PAYARA=/usr/local/payara6(or
setenv PAYARA /usr/local/payara6if you are using acsh-like shell)1. List deployed applications
$PAYARA/bin/asadmin list-applications2. Undeploy the previous version (should match "list-applications" above)
$PAYARA/bin/asadmin undeploy dataverse-6.73. Download and deploy this version
wget https://github.com/IQSS/dataverse/releases/download/v6.7/dataverse-6.7.1.war $PAYARA/bin/asadmin deploy dataverse-6.7.1.warNote: if you have any trouble deploying, stop Payara, remove the following directories, start Payara, and try to deploy again.
Additional documentation:
None.