Re-fix Curation Status bug #11685
Merged
Re-fix Curation Status bug #11685
+22
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofahimIQSS
moved this from Ready for Triage
to Ready for Review ⏩
in IQSS Dataverse Project
stevenwinship
moved this from Ready for Review ⏩
to In Review 🔎
in IQSS Dataverse Project
stevenwinship
approved these changes
Aug 6, 2025
Contributor
stevenwinship
left a comment
stevenwinship
left a comment
There was a problem hiding this comment.
I verified the order shows correct now
github-project-automation
bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
Contributor
|
test done - merging |
github-project-automation
bot
moved this from QA ✅
to Merged 🚀
in IQSS Dataverse Project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: The bug reported in #11684 was originally seen at QDR in May and fixed in this commit, which was part of the initial #11268 PR. However, it appears that other changes in v6.7 have made the issue reappear - I can confirm we are seeing it again at QDR.
The original fix was to add NULLS LAST to the ORDER DESC annotation on the DatasetVersions curationStatuses list. For some reason (we did upgrade to a newer version of the postgres driver), NULLS LAST is no longer putting entries with null createtimes last. This PR adds an explicit sort (using a reverse sort to get DESC order, which I think is still true from the annotation) along with a nullsLast sort which is what appears to no longer happen in the initial retrieval of the list.
Which issue(s) this PR closes:
Special notes for your reviewer:
FWIW: I think this is a better approach than assigning a 'fake' createtime as suggested in the issue.
Suggestions on how to test this: If you can't find a dataset with a pre #11268 curation status (which would have a null createtime in the db), you should be able to add several curationstatus entries and then edit one of them to have a null createtime in the db. Prior to this fix, the entry with null will show as the current status when the page is refreshed. After, it will not.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: added.
Additional documentation: