11634 api get available file categories #11668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
FY26 Sprint 2
This comment has been minimized.
This comment has been minimized.
stevenwinship
moved this from Ready for Review ⏩
to In Review 🔎
in IQSS Dataverse Project
| try { | ||
| Dataset ds = findDatasetOrDie(idSupplied); | ||
| categoriesByName = new ArrayList<>(); | ||
| List<String> datasetFileCategories = dataFileCategoryService.mergeDatasetFileCategories(ds.getCategories()); |
Contributor
There was a problem hiding this comment.
This looks like you're looping through a list twice. Once to build a list of names and another to add the names to the JsonArrayBuilder. I would suggest doing this in a single loop
ie. for (String fieldName : dataFileCategoryService.mergeDatasetFileCategories(ds.getCategories()) { fileCategoriesArrayBuilder.add(fieldName); }
Member
There was a problem hiding this comment.
categoriesByName isn't ever used is it?
Contributor
Author
There was a problem hiding this comment.
Good catch - categoriesByName was copied over from DatasetPage - goes into the jsf popup - not needed for the json return.
This comment has been minimized.
This comment has been minimized.
stevenwinship
approved these changes
Jul 23, 2025
github-project-automation
bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
This comment has been minimized.
This comment has been minimized.
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
Contributor
Looks good to me - merging |
github-project-automation
bot
moved this from QA ✅
to Merged 🚀
in IQSS Dataverse Project
This was referenced Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Adds an api that returns the available file categories for a given dataset. Needed for the SPA for edit tags/files.
Which issue(s) this PR closes:
Special notes for your reviewer: no permissions added. didn't seem necessary - there's no mischief that can be made with the knowledge. perms required for actually updating a file's tags. (inadvertently ran a "source format" on all of Datasets.java instead of just the part I added. review with whitespace off recommended.)
Suggestions on how to test this: add a custom tag to a dataset file confirm that the api returns that custom tag along with the built-in tags.
curl "http://localhost:8080/api/datasets/:persistentId/availableFileCategories?persistentId=doi:10.5072/FK2/4ZOOF9"
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: included
Additional documentation: added to native api doc