Bump org.apache.commons:commons-lang3 from 3.12.0 to 3.18.0 in /modules/dataverse-parent #11632

dependabot · 2025-07-12T01:10:23Z

Bumps org.apache.commons:commons-lang3 from 3.12.0 to 3.18.0.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps org.apache.commons:commons-lang3 from 3.12.0 to 3.18.0. --- updated-dependencies: - dependency-name: org.apache.commons:commons-lang3 dependency-version: 3.18.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>

qqmyers · 2025-07-12T14:16:55Z

Re: test fails: Looks like commons-lang3 now changes ɨ to i, so the keys in these two lines (and in translations of this properties file) need to be updated (or parsing changed):

dataverse/src/main/java/propertyFiles/citation.properties

Lines 4253 to 4254 in 7e16ed3

    
           controlledvocabulary.language.magɨ_(madang_province)=Magɨ (Madang Province) 
        
           controlledvocabulary.language.magɨyi=Magɨyi

pdurbin · 2025-07-17T14:32:13Z

When I run mvn test -Dtest=MetadataBlockTest#testLanguageBundle on develop I get basically no output and the test passes:

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running edu.harvard.iq.dataverse.MetadataBlockTest
Missing count:0
Unused Count:0
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.077 s -- in edu.harvard.iq.dataverse.MetadataBlockTest
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[INFO] 
[INFO] --- jacoco:0.8.11:report (jacoco-after-unit) @ dataverse ---
[INFO] Loading execution data file /Users/PDurbin/github/iqss/dataverse/target/coverage-reports/jacoco-unit.exec
[INFO] Analyzed bundle 'dataverse' with 1113 classes
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------

However, when I switch to this branch, I get the following output and errors:

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running edu.harvard.iq.dataverse.MetadataBlockTest
Missing key:magɨ_(madang_province) controlledvocabulary.language.magi_(madang_province)
Missing key:magɨyi controlledvocabulary.language.magiyi
Unused key:controlledvocabulary.language.magɨyi
Unused key:controlledvocabulary.language.magɨ_(madang_province)
Missing count:2
Unused Count:2
[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.080 s <<< FAILURE! -- in edu.harvard.iq.dataverse.MetadataBlockTest
[ERROR] edu.harvard.iq.dataverse.MetadataBlockTest.testLanguageBundle -- Time elapsed: 0.068 s <<< FAILURE!
org.opentest4j.AssertionFailedError: expected: <0> but was: <2>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:150)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:145)
	at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:531)
	at edu.harvard.iq.dataverse.MetadataBlockTest.testLanguageBundle(MetadataBlockTest.java:122)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

[INFO] 
[INFO] Results:
[INFO] 
[ERROR] Failures: 
[ERROR]   MetadataBlockTest.testLanguageBundle:122 expected: <0> but was: <2>
[INFO] 
[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0
[INFO] 
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------

…ules/dataverse-parent/org.apache.commons-commons-lang3-3.18.0

coveralls · 2025-07-23T20:31:20Z

coverage: 23.225% (+0.06%) from 23.161%
when pulling c9acc2e on dependabot/maven/modules/dataverse-parent/org.apache.commons-commons-lang3-3.18.0
into 7e16ed3 on develop.

stevenwinship · 2025-08-07T13:48:04Z

src/main/java/propertyFiles/citation.properties

-controlledvocabulary.language.magɨ_(madang_province)=Magɨ (Madang Province)
-controlledvocabulary.language.magɨyi=Magɨyi
+controlledvocabulary.language.magi_(madang_province)=Magɨ (Madang Province)
+controlledvocabulary.language.magiyi=Magɨyi


Same issue Phil saw

In citation.tsv the old values are still present:

language Magɨ (Madang Province) gkd 3946 gkd language Magɨyi gmg 3947 gmg

For me MetadataBlockTest is failing:

Missing key:magɨ_(madang_province) controlledvocabulary.language.magɨ_(madang_province)
Missing key:magɨyi controlledvocabulary.language.magɨyi
Unused key:controlledvocabulary.language.magi_(madang_province)
Unused key:controlledvocabulary.language.magiyi
Missing count:2
Unused Count:2

org.opentest4j.AssertionFailedError:
Expected :0
Actual :2

I made the change to citation.tsv as well to fix the failure

github-actions · 2025-08-07T14:47:12Z

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:dependabot-maven-modules-dataverse-parent-org.apache.commons-commons-lang3-3.18.0

ghcr.io/gdcc/configbaker:dependabot-maven-modules-dataverse-parent-org.apache.commons-commons-lang3-3.18.0

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

stevenwinship

Did some extensive testing with the new tsv file both for new installation and upgrade. No issues seen

ofahimIQSS · 2025-08-08T13:07:52Z

tests passing - merging

…e-note reload citation.tsv when upgrading, a follow up to #11632

dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Jul 12, 2025

pdurbin added this to IQSS Dataverse Project Jul 15, 2025

pdurbin moved this to Ready for Triage in IQSS Dataverse Project Jul 15, 2025

ofahimIQSS moved this from Ready for Triage to Ready for Review ⏩ in IQSS Dataverse Project Jul 15, 2025

ofahimIQSS added the Size: 10 A percentage of a sprint. 7 hours. label Jul 15, 2025

cmbz added FY26 Sprint 1 FY26 Sprint 1 (2025-07-02 - 2025-07-16) FY26 Sprint 2 FY26 Sprint 2 (2025-07-16 - 2025-07-30) labels Jul 17, 2025

qqmyers added 3 commits July 23, 2025 14:40

update keys with ascii letter

48f5064

release note

c9acc2e

Merge remote-tracking branch 'IQSS/develop' into dependabot/maven/mod…

9a5748d

…ules/dataverse-parent/org.apache.commons-commons-lang3-3.18.0

This comment has been minimized.

Sign in to view

cmbz added the FY26 Sprint 3 (2025-07-30 - 2025-08-13) label Jul 31, 2025

stevenwinship self-assigned this Aug 7, 2025

stevenwinship moved this from Ready for Review ⏩ to In Review 🔎 in IQSS Dataverse Project Aug 7, 2025

stevenwinship reviewed Aug 7, 2025

View reviewed changes

stevenwinship added 2 commits August 7, 2025 09:51

fix citation.tsv to match citation.properties

9f6b77c

fix citation.tsv to match citation.properties

9634fc9

This comment has been minimized.

Sign in to view

stevenwinship approved these changes Aug 7, 2025

View reviewed changes

github-project-automation bot moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project Aug 7, 2025

stevenwinship removed their assignment Aug 7, 2025

ofahimIQSS moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project Aug 8, 2025

ofahimIQSS self-assigned this Aug 8, 2025

ofahimIQSS merged commit ee3af4a into develop Aug 8, 2025
16 checks passed

github-project-automation bot moved this from QA ✅ to Merged 🚀 in IQSS Dataverse Project Aug 8, 2025

ofahimIQSS deleted the dependabot/maven/modules/dataverse-parent/org.apache.commons-commons-lang3-3.18.0 branch August 8, 2025 13:07

ofahimIQSS removed their assignment Aug 8, 2025

pdurbin added this to the 6.8 milestone Aug 11, 2025

pdurbin added a commit that referenced this pull request Aug 11, 2025

reload citation.tsv when upgrading #11632

2c062bd

pdurbin mentioned this pull request Aug 11, 2025

reload citation.tsv when upgrading, a follow up to #11632 #11735

Merged

scolapasta moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project Aug 12, 2025

cmbz added the FY26 Sprint 4 FY26 Sprint 4 (2025-08-13 - 2025-08-27) label Aug 16, 2025

ofahimIQSS added a commit that referenced this pull request Aug 28, 2025

Merge pull request #11735 from IQSS/11632-commons-lang3-update-releas…

c021fcf

…e-note reload citation.tsv when upgrading, a follow up to #11632

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Bump org.apache.commons:commons-lang3 from 3.12.0 to 3.18.0 in /modules/dataverse-parent #11632

Bump org.apache.commons:commons-lang3 from 3.12.0 to 3.18.0 in /modules/dataverse-parent #11632

Uh oh!

dependabot bot commented on behalf of github Jul 12, 2025

Uh oh!

qqmyers commented Jul 12, 2025

Uh oh!

pdurbin commented Jul 17, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

coveralls commented Jul 23, 2025

Uh oh!

stevenwinship Aug 7, 2025 •

edited

Loading

Uh oh!

stevenwinship Aug 7, 2025

Uh oh!

This comment has been minimized.

github-actions bot commented Aug 7, 2025

Uh oh!

stevenwinship left a comment

Uh oh!

ofahimIQSS commented Aug 8, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Bump org.apache.commons:commons-lang3 from 3.12.0 to 3.18.0 in /modules/dataverse-parent #11632

Bump org.apache.commons:commons-lang3 from 3.12.0 to 3.18.0 in /modules/dataverse-parent #11632

Uh oh!

Conversation

dependabot bot commented on behalf of github Jul 12, 2025

Uh oh!

qqmyers commented Jul 12, 2025

Uh oh!

pdurbin commented Jul 17, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

coveralls commented Jul 23, 2025

Uh oh!

stevenwinship Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stevenwinship Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

github-actions bot commented Aug 7, 2025

Uh oh!

stevenwinship left a comment

Choose a reason for hiding this comment

Uh oh!

ofahimIQSS commented Aug 8, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

stevenwinship Aug 7, 2025 •

edited

Loading