feat: allow non-superusers to list the links of a dataset via API #11492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vera
force-pushed
the
feat/list-dataset-links
branch
from
0c10552 to
e5fd133
Compare
scolapasta
moved this from Ready for Triage
to Ready for Review ⏩
in IQSS Dataverse Project
cmbz
added
FY25 Sprint 23
stevenwinship
moved this from Ready for Review ⏩
to In Review 🔎
in IQSS Dataverse Project
stevenwinship
approved these changes
Jul 11, 2025
github-project-automation
bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
updated version in pom.xml
Contributor
looking good, merging. |
github-project-automation
bot
moved this from QA ✅
to Merged 🚀
in IQSS Dataverse Project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR changes the API for listing the dataverses a dataset has been linked to (
api/datasets/$linked-dataset-id/links) to be accessible for non-superusers.The UI already shows this list to any authenticated user as part of the "Link Dataset" popup (see screenshot), so I think this is a reasonable change.
I've added a test that checks that listing linked dataverses is now possible for non-superusers. The test also confirms that unpublished dataverses are not "leaked" through this list (a linked dataverse is only part of the list if it's either published or the requesting user has permission to view that unpublished dataverse).
Which issue(s) this PR closes:
/
Special notes for your reviewer:
/
Suggestions on how to test this:
I've added a test for this change:
mvn test -Dtest="LinkIT#testListLinks"Does this PR introduce a user interface change? If mockups are available, please link/include them here:
/
Is there a release notes update needed for this change?:
I will add a short release note.
Additional documentation:
/