Switch to new apache client #11440
Merged
Switch to new apache client #11440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/main/java/edu/harvard/iq/dataverse/engine/command/impl/ImportDatasetCommand.java
Dismissed
Show dismissed
Hide dismissed
ofahimIQSS
moved this from Ready for Triage
to Ready for Review ⏩
in IQSS Dataverse Project
cmbz
added
FY25 Sprint 21
sekmiller
approved these changes
Jun 4, 2025
github-project-automation
bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
Contributor
|
@qqmyers Looks good to me - lets discuss the security issue during stand up tomorrow before I merge. Screen.Recording.2025-06-04.at.2.41.39.PM.mov |
Contributor
|
merging as no issues were discovered during testing. |
github-project-automation
bot
moved this from QA ✅
to Merged 🚀
in IQSS Dataverse Project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Addresses https://github.com/IQSS/dataverse/security/dependabot/25 which points out that the version of the Apache HttpClient we used is EOL. This PR does a fairly direct update to use the newer library, staying with 'classic' rather than going to non-blocking calls.
Which issue(s) this PR closes:
Special notes for your reviewer: Did some minor cleanup to drop unneeded throws Exception statements. Two of the example workflow steps changed - not sure how those can be tested other than manually, but not sure they're used (is it worth setting them up?)
Suggestions on how to test this: Check that DataCite PIDs get added/deleted when you create/delete draft datasets.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: