Skip to content

Conversation

@stevenwinship
Copy link
Contributor

@stevenwinship stevenwinship commented Apr 18, 2025

What this PR does / why we need it: No way to clear the fields with the API since empty fields were being ignored

Which issue(s) this PR closes:#11392

Special notes for your reviewer:

Suggestions on how to test this: See FilesIT test

Does this PR introduce a user interface change? If mockups are available, please link/include them here: No

Is there a release notes update needed for this change?: Included

Additional documentation: Included

@stevenwinship stevenwinship self-assigned this Apr 18, 2025
@stevenwinship stevenwinship moved this to In Progress 💻 in IQSS Dataverse Project Apr 18, 2025
@github-actions github-actions bot added FY25 Sprint 21 FY25 Sprint 21 (2025-04-09 - 2025-04-23) GREI Re-arch Issues related to the GREI Dataverse rearchitecture Original size: 10 Size: 10 A percentage of a sprint. 7 hours. SPA.Q2 Not related to any specific Q2 feature Type: Bug a defect labels Apr 18, 2025
@stevenwinship stevenwinship added Feature: API Size: 20 A percentage of a sprint. 14 hours. Size: 30 A percentage of a sprint. 21 hours. (formerly size:33) and removed Size: 10 A percentage of a sprint. 7 hours. Size: 20 A percentage of a sprint. 14 hours. labels Apr 18, 2025
@coveralls
Copy link

coveralls commented Apr 18, 2025

Coverage Status

coverage: 23.174% (-0.008%) from 23.182%
when pulling c465180 on 11392-edit-file-metadata-empty-values
into 74b3bc7 on develop.

@github-actions

This comment has been minimized.

@stevenwinship stevenwinship added Size: 10 A percentage of a sprint. 7 hours. and removed Feature: API Size: 30 A percentage of a sprint. 21 hours. (formerly size:33) labels Apr 18, 2025
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@stevenwinship stevenwinship removed their assignment Apr 22, 2025
@pdurbin pdurbin moved this from Ready for QA ⏩ to In Review 🔎 in IQSS Dataverse Project Jul 14, 2025
@pdurbin pdurbin added this to the 6.8 milestone Jul 14, 2025
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. Thanks. Now that we're mentioning 6.8 explicitly in the guides, I added the 6.8 milestone.

@github-project-automation github-project-automation bot moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project Jul 14, 2025
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@g-saracca g-saracca added SPA.Q3.2025 Not related to any specific Q3 2025 feature and removed SPA.Q2 Not related to any specific Q2 feature labels Jul 16, 2025
@cmbz cmbz added the FY26 Sprint 2 FY26 Sprint 2 (2025-07-16 - 2025-07-30) label Jul 17, 2025
@ofahimIQSS ofahimIQSS self-assigned this Jul 21, 2025
@ofahimIQSS ofahimIQSS moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project Jul 21, 2025
@github-actions
Copy link

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:11392-edit-file-metadata-empty-values
ghcr.io/gdcc/configbaker:11392-edit-file-metadata-empty-values

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@ofahimIQSS
Copy link
Contributor

tests are passing - merging

@ofahimIQSS ofahimIQSS merged commit bfe59f0 into develop Jul 21, 2025
25 checks passed
@github-project-automation github-project-automation bot moved this from QA ✅ to Merged 🚀 in IQSS Dataverse Project Jul 21, 2025
@ofahimIQSS ofahimIQSS deleted the 11392-edit-file-metadata-empty-values branch July 21, 2025 17:28
@ofahimIQSS ofahimIQSS removed their assignment Jul 21, 2025
@pdurbin pdurbin moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project Jul 22, 2025
@cmbz cmbz added the FY26 Sprint 4 FY26 Sprint 4 (2025-08-13 - 2025-08-27) label Aug 16, 2025
@pdurbin
Copy link
Member

pdurbin commented Sep 18, 2025

As @JR-1991 and I have been discussing, this change in behavior resulted in test failures here:

Thanks for putting something in the "breaking changes" API changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY25 Sprint 21 FY25 Sprint 21 (2025-04-09 - 2025-04-23) FY25 Sprint 22 FY25 Sprint 22 (2025-04-23 - 2025-05-07) FY25 Sprint 23 FY25 Sprint 23 (2025-05-07 - 2025-05-21) FY25 Sprint 24 FY25 Sprint 24 (2025-05-21 - 2025-06-04) FY25 Sprint 25 FY25 Sprint 25 (2025-06-04 - 2025-06-18) FY25 Sprint 26 FY25 Sprint 26 (2025-06-18 - 2025-07-02) FY26 Sprint 1 FY26 Sprint 1 (2025-07-02 - 2025-07-16) FY26 Sprint 2 FY26 Sprint 2 (2025-07-16 - 2025-07-30) FY26 Sprint 4 FY26 Sprint 4 (2025-08-13 - 2025-08-27) GREI Re-arch Issues related to the GREI Dataverse rearchitecture Original size: 10 Size: 10 A percentage of a sprint. 7 hours. SPA.Q3.2025 Not related to any specific Q3 2025 feature Type: Bug a defect

Projects

Status: Done 🧹

Development

Successfully merging this pull request may close these issues.

Edit File Metadata API endpoint - ignoring empty values

10 participants