-
Notifications
You must be signed in to change notification settings - Fork 531
File Metadata Update - Empty values clear fields #11439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
pdurbin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good. Thanks. Now that we're mentioning 6.8 explicitly in the guides, I added the 6.8 milestone.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
|
tests are passing - merging |
|
As @JR-1991 and I have been discussing, this change in behavior resulted in test failures here: Thanks for putting something in the "breaking changes" API changelog. |
What this PR does / why we need it: No way to clear the fields with the API since empty fields were being ignored
Which issue(s) this PR closes:#11392
Special notes for your reviewer:
Suggestions on how to test this: See FilesIT test
Does this PR introduce a user interface change? If mockups are available, please link/include them here: No
Is there a release notes update needed for this change?: Included
Additional documentation: Included