Clean up JSON CSL elements #11338
Merged
Clean up JSON CSL elements #11338
+9
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdurbin
approved these changes
Mar 13, 2025
github-project-automation
bot
moved this from Ready for Review ⏩
to Ready for QA ⏩
in IQSS Dataverse Project
pdurbin
reviewed
Mar 13, 2025
Contributor
|
Tested that styled citation works, deaccession, creation of dataset, etc. No issues found merging PR.
|
github-project-automation
bot
moved this from QA ✅
to Merged 🚀
in IQSS Dataverse Project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: The elements that go into the CSL Json aren't HTML ready and, with the current design, we write this into the page for use by the citation script (the original design called an API method to get it, but JSF pages can't call the API with authentication without the optional feature flag).
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this: Use test dataset examples on dataverse-internal - verify no issues with display. Verify styled citations still work.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: